Visitar URL original
gh-99108: Refactor _sha256 & _sha512 into _sha2. by gpshead · Pull Request #101924 · python/cpython · GitHub
Skip to content

gh-99108: Refactor _sha256 & _sha512 into _sha2. - #101924

Merged
gpshead merged 13 commits into
python:mainfrom
gpshead:build/sha2
Feb 16, 2023
Merged

gh-99108: Refactor _sha256 & _sha512 into _sha2.#101924
gpshead merged 13 commits into
python:mainfrom
gpshead:build/sha2

Conversation

@gpshead

@gpshead gpshead commented Feb 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This merges their code. They're backed by the same single HACL* static library, having them be a single module simplifies maintenance.

This should unbreak the wasm enscripten builds that currently fail due to linking in --whole-archive mode and the HACL* library appearing twice.

Long unnoticed error fixed: _sha512.SHA384Type was doubly assigned and was actually SHA512Type. Nobody depends on those internal names.

This is a followup to PRs #101707 and #101917.

@gpshead
pythongh-99108: Refactor _sha256 & _sha512 into _sha2.
fea4cdf 
This merges their code. They're backed by the same single HACL* star static
library, having them be a single module simplifies maintenance.

This should unbreak the wasm enscripten builds that currently fail due to
linking in --whole-archive mode and the HACL* library appearing twice.

Long unnoticed error fixed: `_sha512.SHA384Type` was doubly assigned and was
actually SHA512Type. Nobody depends on those internal names.
@bedevere-bot bedevere-bot mentioned this pull request Feb 15, 2023
Closed
@gpshead gpshead self-assigned this Feb 15, 2023
@gpshead gpshead added extension-modules C modules in the Modules dir build The build process and cross-build labels Feb 15, 2023
@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 15, 2023
@bedevere-bot

bedevere-bot commented Feb 15, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 4c6a4fb 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 15, 2023
@gpshead
gpshead marked this pull request as ready for review February 15, 2023 03:04
erlend-aasland
erlend-aasland reviewed Feb 15, 2023
View reviewed changes
Comment thread configure.ac
Comment thread Modules/sha2module.c Outdated
Comment thread Modules/sha2module.c Outdated
Comment thread Modules/sha2module.c
Comment thread Modules/sha2module.c
Comment thread Modules/sha2module.c Outdated
Comment thread Modules/sha2module.c Outdated
Comment thread Modules/sha2module.c Outdated
@erlend-aasland

erlend-aasland commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

BTW, I'm pretty sure the refleaks are related to #101908.

msprotz
msprotz reviewed Feb 15, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2023-02-15-01-54-06.gh-issue-99108.rjTSic.rst Outdated
@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 16, 2023
@bedevere-bot

bedevere-bot commented Feb 16, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit fb6454d 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 16, 2023
@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 16, 2023
@bedevere-bot

bedevere-bot commented Feb 16, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 32b8f91 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 16, 2023
@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 16, 2023
@bedevere-bot

bedevere-bot commented Feb 16, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit b67918d 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 16, 2023
@gpshead
gpshead merged commit 0b13575 into python:main Feb 16, 2023
@gpshead
gpshead deleted the build/sha2 branch February 16, 2023 06:08
@asottile asottile mentioned this pull request Feb 16, 2023
Closed
picnixz added a commit that referenced this pull request Mar 3, 2025
@picnixz
gh-130149: refactor tests for HMAC (#130150)
8f11af4 
Since we plan to introduce a built-in implementation for HMAC based on HACL*,
it becomes important for the HMAC tests to be flexible enough to avoid code
duplication.

In addition to the new layout based on mixin classes, we extend test coverage by
also testing the `__repr__` of HMAC objects and the HMAC one-shot functions.

We also fix the import to `_sha256` which, since gh-101924, resulted in some tests being
skipped as the module is no more available (its content was moved to the `_sha2` module).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments
@tiran tiran Awaiting requested review from tiran
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
+1 more reviewer
@msprotz msprotz msprotz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@gpshead gpshead

Labels

build The build process and cross-build extension-modules C modules in the Modules dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gpshead @bedevere-bot @erlend-aasland @msprotz