Visitar URL original
gh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` by sobolevn · Pull Request #102722 · python/cpython · GitHub
Skip to content

gh-102721: Improve coverage of _collections_abc._CallableGenericAlias #102722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 2 commits into from
Mar 16, 2023
Merged

gh-102721: Improve coverage of _collections_abc._CallableGenericAlias #102722

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ed3dd8
gh-102721: Improve coverage of `_collections_abc._CallableGenericAlias`
sobolevn Mar 15, 2023
afe8f37
Apply suggestions from code review
sobolevn Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
  • Loading branch information
@sobolevn @AlexWaygood
sobolevn and AlexWaygood authored Mar 15, 2023
commit afe8f372965c54dfc3a416a8b501e8a7abf542e8
15 changes: 9 additions & 6 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1936,11 +1936,12 @@ def test_pickle(self):
]
for alias in samples:
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
s = pickle.dumps(alias, proto)
loaded = pickle.loads(s)
self.assertEqual(alias.__origin__, loaded.__origin__)
self.assertEqual(alias.__args__, loaded.__args__)
self.assertEqual(alias.__parameters__, loaded.__parameters__)
with self.subTest(alias=alias, proto=proto):
s = pickle.dumps(alias, proto)
loaded = pickle.loads(s)
self.assertEqual(alias.__origin__, loaded.__origin__)
self.assertEqual(alias.__args__, loaded.__args__)
self.assertEqual(alias.__parameters__, loaded.__parameters__)

del T_pickle, P_pickle, TS_pickle # cleaning up global state

Expand Down Expand Up @@ -1973,7 +1974,9 @@ def test_type_subst_error(self):
P = ParamSpec('P')
T = TypeVar('T')

with self.assertRaises(TypeError):
pat = "Expected a list of types, an ellipsis, ParamSpec, or Concatenate."

with self.assertRaisesRegex(TypeError, pat):
Callable[P, T][0, int]

def test_type_erasure(self):
Expand Down