Visitar URL original
GH-102973: Slim down Fedora packages in the dev container by hroncok · Pull Request #103283 · python/cpython · GitHub
Skip to content

GH-102973: Slim down Fedora packages in the dev container #103283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 1 commit into from
Apr 24, 2023
Merged

GH-102973: Slim down Fedora packages in the dev container #103283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
GH-102973: Slim down Fedora packages in the dev container 
dnf install /usr/bin/... and dnf-command(builddep) to get exactly what we use.
That way, we abstract away (possibly artificial) package names.

This also fetches a slimmer version of git, called git-core,
which avoids a dependency on Perl.
However, Perl is eventually unfortunately still fetched in the next dnf command.

This declares more used dependencies in the spirit of
"explicit is better than implicit".

Also set install_weak_deps=False to avoid installing unneeded weak dependencies.
  • Loading branch information
@hroncok
hroncok committed Apr 5, 2023
commit ccd3b326ac8802feb17d990f5f4f37653f83090f
4 changes: 2 additions & 2 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ ENV WASMTIME_HOME=/opt/wasmtime
ENV WASMTIME_VERSION=7.0.0
ENV WASMTIME_CPU_ARCH=x86_64

RUN dnf -y --nodocs install git clang xz python3-blurb dnf-plugins-core && \
dnf -y --nodocs builddep python3 && \
RUN dnf -y --nodocs --setopt=install_weak_deps=False install /usr/bin/{blurb,clang,curl,git,ln,tar,xz} 'dnf-command(builddep)' && \
dnf -y --nodocs --setopt=install_weak_deps=False builddep python3 && \
dnf -y clean all

RUN mkdir ${WASI_SDK_PATH} && \
Expand Down