Visitar URL original
gh-87106: Fix `inspect.signature.bind` handling of positional-only arguments with `**kwargs` by jacobtylerwalls · Pull Request #103404 · python/cpython · GitHub
Skip to content

gh-87106: Fix inspect.signature.bind handling of positional-only arguments with **kwargs #103404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 17 commits into from
May 13, 2024
Merged

gh-87106: Fix inspect.signature.bind handling of positional-only arguments with **kwargs #103404

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f2baf1a
gh-87106: Fix `inspect.signature.bind` handling of positional-only ar…
jacobtylerwalls Apr 10, 2023
487e217
fixup: double backticks
jacobtylerwalls Apr 10, 2023
c1e6af2
Merge branch 'main' into issue-87106
jacobtylerwalls Apr 15, 2023
b7cbfe4
Avoid having helper function start with "test"
jacobtylerwalls Apr 15, 2023
600e778
Merge branch 'main' into issue-87106
jacobtylerwalls Nov 19, 2023
eebae66
Merge branch 'main' into issue-87106
jacobtylerwalls May 4, 2024
1c7aa83
Merge branch 'main' into issue-87106
sobolevn May 5, 2024
cc2d7ba
Opt for black style
jacobtylerwalls May 5, 2024
366bb96
Simplify test case
jacobtylerwalls May 5, 2024
2f792eb
Add test cases
jacobtylerwalls May 5, 2024
5951ad9
Use elif
jacobtylerwalls May 5, 2024
2ecde83
Refactor to avoid pop-and-maybe-put-back pattern
jacobtylerwalls May 5, 2024
db2d925
Remove unnecessary cosmetic changes
jacobtylerwalls May 5, 2024
6916290
Test multiple pos-only args passed by keyword
jacobtylerwalls May 5, 2024
1ec398b
Remove superfluous continue
jacobtylerwalls May 10, 2024
f1565de
[tests] Use distinct value for c_po kwarg
jacobtylerwalls May 10, 2024
52facb0
fixup! [tests] Use distinct value for c_po kwarg
jacobtylerwalls May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor to avoid pop-and-maybe-put-back pattern
  • Loading branch information
@jacobtylerwalls
jacobtylerwalls committed May 5, 2024
commit 2ecde833fe273703ff40573491099f5cb544626d
10 changes: 4 additions & 6 deletions Lib/inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3271,6 +3271,9 @@ def _bind(self, args, kwargs, *, partial=False):
# before reaching the last parameter before *args.
continue

if param.kind == _POSITIONAL_ONLY:
continue
Comment thread
jacobtylerwalls marked this conversation as resolved.
Outdated

param_name = param.name
try:
arg_val = kwargs.pop(param_name)
Expand All @@ -3283,13 +3286,8 @@ def _bind(self, args, kwargs, *, partial=False):
param.default is _empty):
raise TypeError('missing a required argument: {arg!r}'. \
format(arg=param_name)) from None

else:
if param.kind == _POSITIONAL_ONLY:
# Restore the param in case there is a kwargs_param
kwargs[param_name] = arg_val
else:
arguments[param_name] = arg_val
arguments[param_name] = arg_val

if kwargs:
if kwargs_param is not None:
Expand Down