Visitar URL original
GH-103906: Remove immortal refcounting in the interpreter by brandtbucher · Pull Request #103909 · python/cpython · GitHub
Skip to content

GH-103906: Remove immortal refcounting in the interpreter #103909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 7 commits into from
May 16, 2023
+476 −516
Merged

GH-103906: Remove immortal refcounting in the interpreter #103909

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1aaf52c
Remove a bunch of refcounting overhead
brandtbucher Apr 26, 2023
446757a
make regen-cases
brandtbucher Apr 26, 2023
138184d
blurb add
brandtbucher Apr 26, 2023
fd95518
fixup
brandtbucher Apr 26, 2023
7f90633
Merge branch 'main' into immortal-interpreter
brandtbucher Apr 29, 2023
733cdb4
Catch up with main
brandtbucher May 16, 2023
56ec571
One more...
brandtbucher May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@brandtbucher
brandtbucher committed Apr 26, 2023
commit fd95518a5b1edea6889ac66842e191168fe69e26
10 changes: 5 additions & 5 deletions Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ dummy_func(
ERROR_IF(res == NULL, error);
}

inst(UNARY_NOT, (value -- res)) { // XXX
inst(UNARY_NOT, (value -- res)) {
int err = PyObject_IsTrue(value);
DECREF_INPUTS();
ERROR_IF(err < 0, error);
Expand Down Expand Up @@ -2014,7 +2014,7 @@ dummy_func(
CHECK_EVAL_BREAKER();
}

inst(POP_JUMP_IF_FALSE, (cond -- )) { // XXX
inst(POP_JUMP_IF_FALSE, (cond -- )) {
if (Py_IsFalse(cond)) {

@sunmy2019 sunmy2019 Apr 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause a performance change, since formerly IsTrue then IsFalse, now IsFalse then IsTrue

Though this comparison is lightweight.

@brandtbucher brandtbucher Apr 27, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I doubt it.

JUMPBY(oparg);
}
Expand All @@ -2030,7 +2030,7 @@ dummy_func(
}
}

inst(POP_JUMP_IF_TRUE, (cond -- )) { // XXX
inst(POP_JUMP_IF_TRUE, (cond -- )) {
if (Py_IsTrue(cond)) {
JUMPBY(oparg);
}
Expand All @@ -2046,14 +2046,14 @@ dummy_func(
}
}

inst(POP_JUMP_IF_NOT_NONE, (value -- )) { // XXX
inst(POP_JUMP_IF_NOT_NONE, (value -- )) {
if (!Py_IsNone(value)) {
DECREF_INPUTS();
JUMPBY(oparg);
}
}

inst(POP_JUMP_IF_NONE, (value -- )) { // XXX
inst(POP_JUMP_IF_NONE, (value -- )) {
if (Py_IsNone(value)) {
JUMPBY(oparg);
}
Expand Down