Visitar URL original
gh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes by AlexWaygood · Pull Request #104014 · python/cpython · GitHub
Skip to content

gh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes #104014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 2 commits into from
Apr 30, 2023
Merged

gh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes #104014

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53859e4
Ensure test_calendar.CalendarTestCase.test_deprecation_warning consis…
AlexWaygood Apr 30, 2023
a24e9b4
Use assertWarnsRegex
AlexWaygood Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Ensure test_calendar.CalendarTestCase.test_deprecation_warning consis… 
…tently passes
  • Loading branch information
@AlexWaygood
AlexWaygood committed Apr 30, 2023
commit 53859e410c58b1e103cf61064d2b205e4917e01b
1 change: 1 addition & 0 deletions Lib/test/test_calendar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,7 @@ def test_format(self):
class CalendarTestCase(unittest.TestCase):

def test_deprecation_warning(self):
warnings.resetwarnings()

@JelleZijlstra JelleZijlstra Apr 30, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't we using self.assertWarns?

@AlexWaygood AlexWaygood Apr 30, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a reason not to use self.assertWarns. I just made the minimal change to fix the issue. Looking through the previous PR, it doesn't look like using assertWarns(Regex) was suggested, so the contributor may not have been aware of it.

@JelleZijlstra JelleZijlstra Apr 30, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's switch to assertWarnsRegex, then we don't have to do all this manual manipulation of the warnings machinery.

@AlexWaygood AlexWaygood Apr 30, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, sounds good

with warnings.catch_warnings(record=True) as w:
calendar.January
self.assertEqual(len(w), 1)
Expand Down