Visitar URL original
GH-96803: Document and test new unstable internal frame API functions by markshannon · Pull Request #104211 · python/cpython · GitHub
Skip to content

GH-96803: Document and test new unstable internal frame API functions - #104211

Merged
markshannon merged 9 commits into
python:mainfrom
faster-cpython:doc-internal-frame-api
May 18, 2023
Merged

GH-96803: Document and test new unstable internal frame API functions#104211
markshannon merged 9 commits into
python:mainfrom
faster-cpython:doc-internal-frame-api

Conversation

@markshannon

@markshannon markshannon commented May 5, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot mentioned this pull request May 5, 2023
Open
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting core review labels May 5, 2023
carljm
carljm reviewed May 5, 2023
View reviewed changes
Comment thread Doc/c-api/frame.rst Outdated
Comment thread Doc/c-api/frame.rst Outdated
Comment thread Doc/c-api/frame.rst Outdated
Comment thread Doc/c-api/frame.rst Outdated
Comment thread Doc/c-api/frame.rst Outdated
@markshannon markshannon changed the title GH-96803: Document new unstable internal frame API functions GH-96803: Document and test new unstable internal frame API functions May 9, 2023
@markshannon markshannon closed this May 9, 2023
@carljm

carljm commented May 9, 2023

Copy link
Copy Markdown
Member

@markshannon Did you intend to close this?

@markshannon markshannon reopened this May 9, 2023
@markshannon

markshannon commented May 9, 2023

Copy link
Copy Markdown
Member Author

I tried to close and reopen it earlier to force it to update, but GitHub was unwell earlier today.

@markshannon

markshannon commented May 9, 2023

Copy link
Copy Markdown
Member Author

Latest commits still aren't showing up 😕

@markshannon markshannon closed this May 9, 2023
@markshannon markshannon reopened this May 9, 2023
@markshannon

markshannon commented May 9, 2023

Copy link
Copy Markdown
Member Author

Merging main seems to woken GitHub up.

carljm
carljm approved these changes May 9, 2023
View reviewed changes
Comment thread Doc/c-api/frame.rst Outdated
Comment thread Doc/c-api/frame.rst
@markshannon @carljm
Apply suggestions from code review
86865b5 
Co-authored-by: Carl Meyer <carl@oddbird.net>
erlend-aasland
erlend-aasland reviewed May 16, 2023
View reviewed changes
Comment thread Doc/c-api/frame.rst Outdated
@markshannon @erlend-aasland
Update Doc/c-api/frame.rst
31e386c 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@markshannon
markshannon merged commit cfa517d into python:main May 18, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 18, 2023
@carljm
Merge branch 'main' into nestedcomps
54095f0 
* main:
  pythongh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols (python#104622)
  pythongh-104623: Update Windows installer to use SQLite 3.42.0 (python#104625)
  pythongh-104050: Add more type annotations to Argument Clinic (python#104628)
  pythongh-104629: Don't skip test_clinic if _testclinic is missing (python#104630)
  pythongh-104549: Set __module__ on TypeAliasType (python#104550)
  pythongh-104050: Improve some typing around `default`s and sentinel values (python#104626)
  pythongh-104146: Remove unused vars from Argument Clinic (python#104627)
  pythongh-104615: don't make unsafe swaps in apply_static_swaps (python#104620)
  pythonGH-104484: Add case_sensitive argument to `pathlib.PurePath.match()` (pythonGH-104565)
  pythonGH-96803: Document and test new unstable internal frame API functions (pythonGH-104211)
  pythonGH-104580: Don't cache eval breaker in interpreter (pythonGH-104581)
@markshannon
markshannon deleted the doc-internal-frame-api branch September 26, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner left review comments
@carljm carljm carljm approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markshannon @carljm @AA-Turner @erlend-aasland @bedevere-bot