Visitar URL original
gh-91896: Improve visibility of `ByteString` deprecation warnings by AlexWaygood · Pull Request #104294 · python/cpython · GitHub
Skip to content

gh-91896: Improve visibility of ByteString deprecation warnings #104294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 3 commits into from
May 12, 2023
Merged

gh-91896: Improve visibility of ByteString deprecation warnings #104294

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
424486a
gh-91896: Improve visibility of `ByteString` deprecation warnings
AlexWaygood May 8, 2023
8015ba3
Fix `test_regrtest` (hopefully)
AlexWaygood May 8, 2023
67973d1
Multiple inheritance with typing.ByteString also emits a warning
AlexWaygood May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Multiple inheritance with typing.ByteString also emits a warning
  • Loading branch information
@AlexWaygood
AlexWaygood committed May 8, 2023
commit 67973d171e188b33cd7b06cedea740b348c098f1
6 changes: 3 additions & 3 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6011,9 +6011,9 @@ def test_bytestring(self):
with self.assertWarns(DeprecationWarning):
self.assertIsInstance(bytearray(b''), ByteString)
with self.assertWarns(DeprecationWarning):
class Foo(ByteString):
def __len__(self): return 42
def __getitem__(self, n): return 42
class Foo(ByteString): ...
with self.assertWarns(DeprecationWarning):
class Bar(ByteString, typing.Awaitable): ...

def test_list(self):
self.assertIsSubclass(list, typing.List)
Expand Down