Visitar URL original
gh-89886: Rely on HAVE_SYS_TIME_H by erlend-aasland · Pull Request #105058 · python/cpython · GitHub
Skip to content

gh-89886: Rely on HAVE_SYS_TIME_H - #105058

Merged
erlend-aasland merged 8 commits into
python:mainfrom
erlend-aasland:sys/time.h
Jun 1, 2023
Merged

gh-89886: Rely on HAVE_SYS_TIME_H#105058
erlend-aasland merged 8 commits into
python:mainfrom
erlend-aasland:sys/time.h

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Quoting autoupdate (v2.71):

All current systems provide time.h; it need not be checked for.
Not all systems provide sys/time.h, but those that do, all allow
you to include it and time.h simultaneously.

@erlend-aasland
pythongh-89886: Rely on HAVE_SYS_TIME_H
1a8d41e 
Quoting autoconf (v2.71):

    All current systems provide time.h; it need not be checked for.
    Not all systems provide sys/time.h, but those that do, all allow
    you to include it and time.h simultaneously.
@erlend-aasland
erlend-aasland requested a review from corona10 as a code owner May 29, 2023 11:54
@erlend-aasland
erlend-aasland requested review from gpshead and zware May 29, 2023 11:54
@bedevere-bot bedevere-bot mentioned this pull request May 29, 2023
Closed
@hugovk hugovk mentioned this pull request May 29, 2023
Merged
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023
@bedevere-bot

bedevere-bot commented May 29, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit de000c6 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023
@erlend-aasland erlend-aasland added the needs backport to 3.12 only security fixes label May 29, 2023
@erlend-aasland

erlend-aasland commented May 29, 2023

Copy link
Copy Markdown
Contributor Author

On hold until test_import and test_peg_generator issues have been resolved on main.

zware
zware reviewed May 30, 2023
View reviewed changes
Comment thread Modules/expat/xmlparse.c Outdated
Comment thread configure.ac Outdated
@erlend-aasland
Pull in main
f3bb618
@erlend-aasland
Address review: remove confusingly named 'have_libexpat'
92350d7 
Simply use ac_cv_header_sys_time_h for PY_STDLIB_MOD
erlend-aasland
erlend-aasland commented May 30, 2023
View reviewed changes
Comment thread configure.ac Outdated
@erlend-aasland

erlend-aasland commented May 31, 2023

Copy link
Copy Markdown
Contributor Author

Ok, I think we can land this now. Thanks for the review! It helps with more eyes 👀

@erlend-aasland
erlend-aasland merged commit 9ab587b into python:main Jun 1, 2023
@miss-islington

miss-islington commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@erlend-aasland
erlend-aasland deleted the sys/time.h branch June 1, 2023 11:37
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2023
@erlend-aasland @miss-islington
pythongh-89886: Rely on HAVE_SYS_TIME_H (pythonGH-105058)
4a4bc4f 
Quoting autoconf (v2.71):

    All current systems provide time.h; it need not be checked for.
    Not all systems provide sys/time.h, but those that do, all allow
    you to include it and time.h simultaneously.
(cherry picked from commit 9ab587b)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot

bedevere-bot commented Jun 1, 2023

Copy link
Copy Markdown

GH-105192 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 1, 2023
erlend-aasland added a commit that referenced this pull request Jun 1, 2023
@miss-islington @erlend-aasland
[3.12] gh-89886: Rely on HAVE_SYS_TIME_H (GH-105058) (#105192)
6375287 
Quoting autoconf (v2.71):

    All current systems provide time.h; it need not be checked for.
    Not all systems provide sys/time.h, but those that do, all allow
    you to include it and time.h simultaneously.

(cherry picked from commit 9ab587b)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
This was referenced Jun 1, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware left review comments
@brettcannon brettcannon brettcannon approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@gpshead gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @bedevere-bot @miss-islington @brettcannon @zware