Visitar URL original
gh-102251: Explicitly free state for test modules with state in test_import by sunmy2019 · Pull Request #105085 · python/cpython · GitHub
Skip to content

gh-102251: Explicitly free state for test modules with state in test_import - #105085

Merged
erlend-aasland merged 8 commits into
python:mainfrom
sunmy2019:gh-102251-2
May 31, 2023
Merged

gh-102251: Explicitly free state for test modules with state in test_import#105085
erlend-aasland merged 8 commits into
python:mainfrom
sunmy2019:gh-102251-2

Conversation

@sunmy2019

@sunmy2019 sunmy2019 commented May 30, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The module state is not cleared in the clean-up functions. This PR adds one clean-up function for it.

This fixes the second issue mentioned in #103879 (comment)

@bedevere-bot bedevere-bot mentioned this pull request May 30, 2023
Closed
@erlend-aasland

erlend-aasland commented May 30, 2023

Copy link
Copy Markdown
Contributor

Can you update the PR title to reflect the actual change?

@sunmy2019 sunmy2019 changed the title gh-102251: Fix ref leaks in test_import gh-102251: Add clean-up function for _testsinglephase_with_state May 30, 2023
erlend-aasland
erlend-aasland reviewed May 30, 2023
View reviewed changes
Comment thread Modules/_testsinglephase.c Outdated
erlend-aasland
erlend-aasland reviewed May 30, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Outdated
Comment thread Lib/test/test_import/__init__.py Outdated
sunmy2019
sunmy2019 commented May 30, 2023
View reviewed changes
Comment thread Modules/_testsinglephase.c Outdated
sunmy2019
sunmy2019 commented May 30, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Outdated
sunmy2019
sunmy2019 commented May 30, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Outdated
erlend-aasland
erlend-aasland reviewed May 30, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Outdated
@sunmy2019 @erlend-aasland
Update Lib/test/test_import/__init__.py
a0f5bb7 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland
erlend-aasland reviewed May 30, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Outdated
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 30, 2023
@bedevere-bot

bedevere-bot commented May 30, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 26a9ede 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 30, 2023
@brettcannon
brettcannon removed their request for review May 30, 2023 19:19
@sunmy2019 sunmy2019 mentioned this pull request May 31, 2023
Closed
@erlend-aasland erlend-aasland changed the title gh-102251: Add clean-up function for _testsinglephase_with_state gh-102251: Explicitly free state for test modules with state in test_import May 31, 2023
@erlend-aasland

erlend-aasland commented May 31, 2023

Copy link
Copy Markdown
Contributor

Approved by Eric in #104796 (review), as part of a larger PR.

@erlend-aasland
erlend-aasland merged commit a99b9d9 into python:main May 31, 2023
@miss-islington

miss-islington commented May 31, 2023

Copy link
Copy Markdown
Contributor

Thanks @sunmy2019 for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2023
@sunmy2019 @erlend-aasland @miss-islington
pythongh-102251: Explicitly free state for test modules with state in…
4e1a1e1 
… test_import (pythonGH-105085)

(cherry picked from commit a99b9d9)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot

bedevere-bot commented May 31, 2023

Copy link
Copy Markdown

GH-105170 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 31, 2023
erlend-aasland added a commit that referenced this pull request May 31, 2023
@miss-islington @sunmy2019 @erlend-aasland
[3.12] gh-102251: Explicitly free state for test modules with state i…
8b51666 
…n test_import (GH-105085) (#105170)

(cherry picked from commit a99b9d9)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
sunmy2019 added a commit to sunmy2019/cpython that referenced this pull request Jun 1, 2023
@sunmy2019
rebase after changes to python#105085
695fd16
This was referenced Jun 2, 2023
Merged
Closed
@sunmy2019
sunmy2019 deleted the gh-102251-2 branch June 23, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@encukou encukou Awaiting requested review from encukou
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sunmy2019 @erlend-aasland @bedevere-bot @miss-islington