Visitar URL original
gh-107805: Fix signatures of module-level generated functions in `turtle` by sobolevn · Pull Request #107807 · python/cpython · GitHub
Skip to content

gh-107805: Fix signatures of module-level generated functions in turtle #107807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 7 commits into from
Sep 1, 2023
+45 −19
Merged

gh-107805: Fix signatures of module-level generated functions in turtle #107807

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
40ee61d
gh-107805: Fix signatures of module-level generated functions in `tur…
sobolevn Aug 9, 2023
03ea67d
Fix CI
sobolevn Aug 9, 2023
7f71ffd
Fix CI
sobolevn Aug 9, 2023
43f131f
Use patma
sobolevn Aug 10, 2023
51f5bf0
Better error message
sobolevn Aug 10, 2023
438dcbc
Address review
sobolevn Aug 21, 2023
ac50e7f
Merge branch 'main' into issue-107805
AlexWaygood Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review
  • Loading branch information
@sobolevn
sobolevn committed Aug 21, 2023
commit 438dcbc9606d4a655e167815ea94c49f3b56c837
13 changes: 3 additions & 10 deletions Lib/test/test_turtle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,6 @@ def test_teleport(self):
class TestModuleLevel(unittest.TestCase):
def test_all_signatures(self):
import inspect
import types

known_signatures = {
'teleport':
Expand All @@ -475,17 +474,11 @@ def test_all_signatures(self):
'pen': '(pen=None, **pendict)',
}

for name in turtle.__all__:
obj = getattr(turtle, name)
if not isinstance(obj, types.FunctionType):
continue

for name in known_signatures:
with self.subTest(name=name):
# All functions must produce correct signatures:
obj = getattr(turtle, name)
sig = inspect.signature(obj)

if name in known_signatures:
self.assertEqual(str(sig), known_signatures[name])
self.assertEqual(str(sig), known_signatures[name])


if __name__ == '__main__':
Expand Down