Visitar URL original
gh-114281: Remove incorrect type hints from `asyncio.staggered` by sobolevn · Pull Request #114282 · python/cpython · GitHub
Skip to content

gh-114281: Remove incorrect type hints from asyncio.staggered #114282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-Turner merged 3 commits into from
Jan 20, 2024
Merged

gh-114281: Remove incorrect type hints from asyncio.staggered #114282

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7206e41
gh-114281: Improve type hints in `asyncio/staggered.py`
sobolevn Jan 19, 2024
2ea1eda
Remove type annotations from `asyncio.staggered`
sobolevn Jan 20, 2024
81f0ab8
Update Misc/NEWS.d/next/Library/2024-01-19-12-05-22.gh-issue-114281.H…
sobolevn Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-114281: Improve type hints in asyncio/staggered.py
  • Loading branch information
@sobolevn
sobolevn committed Jan 19, 2024
commit 7206e4175ead4a82b335a8b90b970e8b3453ea14
17 changes: 9 additions & 8 deletions Lib/asyncio/staggered.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
__all__ = 'staggered_race',

import contextlib
import typing
from collections.abc import Awaitable, Callable, Iterable
from typing import Any

from . import events
from . import exceptions as exceptions_mod
Expand All @@ -12,14 +13,14 @@


async def staggered_race(
coro_fns: typing.Iterable[typing.Callable[[], typing.Awaitable]],
delay: typing.Optional[float],
coro_fns: Iterable[Callable[[], Awaitable[Any]]],
delay: float | None,
*,
loop: events.AbstractEventLoop = None,
) -> typing.Tuple[
typing.Any,
typing.Optional[int],
typing.List[typing.Optional[Exception]]
loop: events.AbstractEventLoop | None = None,
) -> tuple[
Any,
int | None,
list[Exception | None]
]:
"""Run coroutines with staggered start times and take the first to finish.

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-01-19-12-05-22.gh-issue-114281.H5JQe4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve type hints in ``Lib/asyncio/staggered.py``.
Comment thread
sobolevn marked this conversation as resolved.
Outdated