Visitar URL original
gh-117657: Fix QSBR race condition by SonicField · Pull Request #118843 · python/cpython · GitHub
Skip to content

gh-117657: Fix QSBR race condition #118843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 14 commits into from
May 10, 2024
Merged

gh-117657: Fix QSBR race condition #118843

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f3a362d
gh-117657: initialize_new_array
SonicField May 9, 2024
ec921f7
gh-118817: Fix `asyncio REPL` on Windows (#118819)
Eclips4 May 9, 2024
154a3f5
gh-117657: Acquire a critical section around `SemLock.__{enter,exit}_…
mpage May 9, 2024
a6bc4e3
gh-118773: Use language-invariant SDDL string instead of aliases for …
zooba May 9, 2024
63af4b5
gh-118849: Fix "code will never be executed" warning in `dictobject.c…
sobolevn May 9, 2024
fa80517
gh-118561: Fix crash involving list.extend in free-threaded build (#1…
colesbury May 9, 2024
e0bb384
gh-116984: Make mimalloc header includes relative to the current file…
colesbury May 9, 2024
888d3d7
gh-118846: Fix PGO tests in free-threaded build (#118862)
colesbury May 9, 2024
64a7f49
gh-117657: Replace TSAN suppresions with more specific rules (#118722)
swtaarrs May 9, 2024
bb8677d
gh-118851: Default ctx arguments to AST constructors to Load() (#118854)
JelleZijlstra May 9, 2024
9c4ae02
Revert "gh-115432: Add critical section variant that handles a NULL o…
colesbury May 9, 2024
6502eb3
Docs: fix typos in documentation (GH-118815)
xyb May 10, 2024
1dff338
Merge branch 'python:main' into main
SonicField May 10, 2024
0f901c9
gh-117657: initialize_new_array remove suppresion
SonicField May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-116984: Make mimalloc header includes relative to the current file (… 
…#118808)

Some embedders and extensions include parts of the internal API. The
pycore_mimalloc.h file is transitively include by a number of other
internal headers. This avoids include errors for code that was
already including those headers.
  • Loading branch information
@colesbury @SonicField
colesbury authored and SonicField committed May 10, 2024
commit e0bb384da1eff6868e638f00a5fa2ff22563c055
4 changes: 2 additions & 2 deletions Include/internal/mimalloc/mimalloc/internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ terms of the MIT license. A copy of the license can be found in the file
// functions and macros.
// --------------------------------------------------------------------------

#include "mimalloc/types.h"
#include "mimalloc/track.h"
#include "types.h"
#include "track.h"

#if (MI_DEBUG>0)
#define mi_trace_message(...) _mi_trace_message(__VA_ARGS__)
Expand Down
2 changes: 1 addition & 1 deletion Include/internal/mimalloc/mimalloc/types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ terms of the MIT license. A copy of the license can be found in the file

#include <stddef.h> // ptrdiff_t
#include <stdint.h> // uintptr_t, uint16_t, etc
#include "mimalloc/atomic.h" // _Atomic
#include "atomic.h" // _Atomic

#ifdef _MSC_VER
#pragma warning(disable:4214) // bitfield is not int
Expand Down
6 changes: 3 additions & 3 deletions Include/internal/pycore_mimalloc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ typedef enum {
# define MI_TSAN 1
#endif

#include "mimalloc.h"
#include "mimalloc/types.h"
#include "mimalloc/internal.h"
#include "mimalloc/mimalloc.h"
#include "mimalloc/mimalloc/types.h"
#include "mimalloc/mimalloc/internal.h"
#endif

#ifdef Py_GIL_DISABLED
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/C API/2024-05-08-23-14-06.gh-issue-116984.5sgcDo.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Make mimalloc includes relative to the current file to avoid embedders or
extensions needing to include ``Internal/mimalloc`` if they are already
including internal CPython headers.