Visitar URL original
gh-110383: Document `socket.makefile()` accepts combined modes by squeakyboots 路 Pull Request #119150 路 python/cpython 路 GitHub
Skip to content

gh-110383: Document socket.makefile() accepts combined modes #119150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 4 commits into from
May 21, 2024
Merged

gh-110383: Document socket.makefile() accepts combined modes #119150

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc72329
Document `socket.makefile()` accepts combined modes
squeakyboots May 18, 2024
2e8d690
Merge branch 'python:main' into socket.makefile-doc-modes
squeakyboots May 20, 2024
81f461e
Merge branch 'python:main' into socket.makefile-doc-modes
squeakyboots May 20, 2024
20ded2e
Document `socket.makefile()` accepts combined modes in `Lib/socket.py`
squeakyboots May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Document socket.makefile() accepts combined modes in Lib/socket.py
  • Loading branch information
@squeakyboots
squeakyboots committed May 20, 2024
commit 20ded2e73b8f1dd7db81271bfd65f4f2930e27ec
3 changes: 2 additions & 1 deletion Lib/socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,8 @@ def makefile(self, mode="r", buffering=None, *,
"""makefile(...) -> an I/O stream connected to the socket

The arguments are as for io.open() after the filename, except the only
supported mode values are 'r' (default), 'w' and 'b'.
supported mode values are 'r' (default), 'w', 'b', or a combination of
those.
"""
# XXX refactor to share code?
if not set(mode) <= {"r", "w", "b"}:
Expand Down