Visitar URL original
gh-119584: Fix test_import Failed Assertion by ericsnowcurrently · Pull Request #119623 · python/cpython · GitHub
Skip to content

gh-119584: Fix test_import Failed Assertion #119623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 5 commits into from
May 27, 2024
Merged

gh-119584: Fix test_import Failed Assertion #119623

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9ecfce
Clear m_index when clearing a singlephase extension.
ericsnowcurrently May 27, 2024
b01ac6e
Add a note about the check-state-first modules.
ericsnowcurrently May 27, 2024
6054a7d
Clear the check-state-first modules after loading them.
ericsnowcurrently May 27, 2024
7a23841
Fix _modules_by_index_check().
ericsnowcurrently May 27, 2024
3699d15
Move a line up.
ericsnowcurrently May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix _modules_by_index_check().
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed May 27, 2024
commit 7a23841d787c07a84b5537095768ae1eb4e85fa6
2 changes: 1 addition & 1 deletion Python/import.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ _modules_by_index_check(PyInterpreterState *interp, Py_ssize_t index)
if (MODULES_BY_INDEX(interp) == NULL) {
return "Interpreters module-list not accessible.";
}
if (index > PyList_GET_SIZE(MODULES_BY_INDEX(interp))) {
if (index >= PyList_GET_SIZE(MODULES_BY_INDEX(interp))) {
return "Module index out of bounds.";
}
return NULL;
Expand Down