Visitar URL original
gh-126133: Only use start year in PSF copyright, remove end years by hugovk · Pull Request #126236 · python/cpython · GitHub
Skip to content

gh-126133: Only use start year in PSF copyright, remove end years - #126236

Merged
hugovk merged 3 commits into
python:mainfrom
hugovk:copyright-psf-single-year
Nov 12, 2024
Merged

gh-126133: Only use start year in PSF copyright, remove end years#126236
hugovk merged 3 commits into
python:mainfrom
hugovk:copyright-psf-single-year

Conversation

@hugovk

@hugovk hugovk commented Oct 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Oct 31, 2024
Closed
Wulian233
Wulian233 reviewed Oct 31, 2024
View reviewed changes
Comment thread Lib/email/_parseaddr.py
Comment thread Lib/email/feedparser.py
AA-Turner
AA-Turner reviewed Oct 31, 2024
View reviewed changes
Comment thread Doc/copyright.rst

@AA-Turner AA-Turner Oct 31, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case (where there's multiple consecutive entries) makes me slightly prefer the -present form, as we have [1991-1995], [1995-2000], [2001], and then 2001 again. Or, we could remove the end years from the old entries, but I assume that would be more difficult to do?

A

AA-Turner
AA-Turner reviewed Oct 31, 2024
View reviewed changes
Comment thread Lib/email/__init__.py
@@ -1,4 +1,4 @@
# Copyright (C) 2001-2007 Python Software Foundation
# Copyright (C) 2001 Python Software Foundation

@AA-Turner AA-Turner Oct 31, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove the copyright comments in files where the sole holder is the PSF? The general licence would cover this, I think?

@Wulian233 Wulian233 Oct 31, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too
#126133 (comment)

@gpshead gpshead Nov 11, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my personal preference is to not remove statements that exist. just get us out of the continually sometimes updating the year heck. :)

vstinner
vstinner approved these changes Nov 7, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk
hugovk marked this pull request as ready for review November 12, 2024 13:58
@hugovk
hugovk requested review from a team and rhettinger as code owners November 12, 2024 13:58
@hugovk
hugovk merged commit 91f4908 into python:main Nov 12, 2024
@hugovk
hugovk deleted the copyright-psf-single-year branch November 12, 2024 13:59
@hugovk hugovk mentioned this pull request Nov 25, 2024
Merged
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@hugovk @picnixz
pythongh-126133: Only use start year in PSF copyright, remove end yea…
d4d543a 
…rs (python#126236)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@hugovk @ebonnal
pythongh-126133: Only use start year in PSF copyright, remove end yea…
fe5e620 
…rs (python#126236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner left review comments
@gpshead gpshead gpshead approved these changes
@vstinner vstinner vstinner approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
+1 more reviewer
@Wulian233 Wulian233 Wulian233 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hugovk @gpshead @vstinner @AA-Turner @Wulian233