add assert to make sure the immortal bit is not set on subclasses

markshannon · Jan 29, 2025 · Dec 4, 2024 · Dec 4, 2024 · Dec 5, 2024 · Dec 5, 2024
commit f76c0e2a58ad5cb8c9b6ce476f8d4cbcd16868f1
diff --git a/Objects/longobject.c b/Objects/longobject.c
@@ -3620,7 +3620,9 @@ static inline int
 _long_is_small_int(PyObject *op)
 {
     PyLongObject *long_object = (PyLongObject *)op;
-    return (long_object->long_value.lv_tag & IMMORTALITY_BIT_MASK) != 0;
+    int is_small_int = (long_object->long_value.lv_tag & IMMORTALITY_BIT_MASK) != 0;
+    assert((!is_small_int) || PyLong_CheckExact(op));
+    return is_small_int;
 }
 
 void
@@ -3649,7 +3651,6 @@ long_dealloc(PyObject *self)
          *
          * See PEP 683, section Accidental De-Immortalizing for details
          */
-        assert(0);
         _Py_SetImmortal(self);
         return;
     }