Visitar URL original
gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier by WolframAlph · Pull Request #131830 · python/cpython · GitHub
Skip to content

gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier #131830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eclips4 merged 11 commits into from
May 4, 2025
Merged

gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier #131830

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
678b085
rename ast_opt.c -> ast_process.c
WolframAlph Mar 28, 2025
e080e27
_PyASTOptimizeState -> _PyASTProcessState
WolframAlph Mar 28, 2025
5153ea5
_PyAST_Optimize -> _PyAST_Process
WolframAlph Mar 28, 2025
ad5d080
_PyCompile_AstOptimize -> _PyCompile_AstProcess
WolframAlph Mar 28, 2025
3a6abef
add news
WolframAlph Mar 28, 2025
e2a3cbc
address review
WolframAlph Mar 28, 2025
2d1bc6f
mention full file path
WolframAlph Mar 28, 2025
3b43460
rename process to preprocess
WolframAlph May 4, 2025
72cca4f
_PyASTProcessState -> _PyASTPreprocessState
WolframAlph May 4, 2025
8a59650
update comment
WolframAlph May 4, 2025
a30846d
Merge branch 'main' into rename-ast-opt
Eclips4 May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review
  • Loading branch information
@WolframAlph
WolframAlph committed May 4, 2025
commit e2a3cbc84e37ae935d7dc2e004eb21c0cc2e2cd6
3 changes: 2 additions & 1 deletion Misc/NEWS.d/next/Core_and_Builtins/2025-03-28-15-06-55.gh-issue-126835.IpcMTn.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
Move constant folding to the peephole optimizer. Rename AST optimization
Comment thread
AA-Turner marked this conversation as resolved.
related files/structs/functions.
related files (ast_opt.c -> ast_process.c), structs (_PyASTOptimizeState -> _PyASTProcessState)
and functions (_PyAST_Optimize -> _PyAST_Process, _PyCompile_AstOptimize -> _PyCompile_AstProcess).
2 changes: 1 addition & 1 deletion Python/ast_process.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,7 @@ astfold_type_param(type_param_ty node_, PyArena *ctx_, _PyASTProcessState *state

int
_PyAST_Process(mod_ty mod, PyArena *arena, PyObject *filename, int optimize,
int ff_features, int syntax_check_only)
int ff_features, int syntax_check_only)
{
_PyASTProcessState state;
memset(&state, 0, sizeof(_PyASTProcessState));
Expand Down
2 changes: 1 addition & 1 deletion Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1482,7 +1482,7 @@ _PyAST_Compile(mod_ty mod, PyObject *filename, PyCompilerFlags *pflags,

int
_PyCompile_AstProcess(mod_ty mod, PyObject *filename, PyCompilerFlags *cf,
int optimize, PyArena *arena, int no_const_folding)
int optimize, PyArena *arena, int no_const_folding)
{
_PyFutureFeatures future;
if (!_PyFuture_FromAST(mod, filename, &future)) {
Expand Down