Visitar URL original
gh-140550: Update xxlimited with 3.15 limited API & PEP 697 by encukou · Pull Request #142827 · python/cpython · GitHub
Skip to content

gh-140550: Update xxlimited with 3.15 limited API & PEP 697 #142827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 25 commits into from
May 13, 2026
+1,062 −164
Merged

gh-140550: Update xxlimited with 3.15 limited API & PEP 697 #142827

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
8147b92
Copy xxlimited to xxlimited_3_13
encukou Dec 15, 2025
65f3fd0
Run tests for all the xxlimited* modules
encukou Dec 15, 2025
aa43538
Adjust module names in the 3_13 module
encukou Dec 15, 2025
323695f
Update xxlimited to 3.15 limited API (with opaque PyObject)
encukou Dec 15, 2025
597652b
Comments & cleanups
encukou Dec 16, 2025
22464eb
Add Py_mod_abi
encukou Dec 16, 2025
cc5e8f3
Remove unused import
encukou Dec 16, 2025
945b450
Don't flag static PyABIInfo variables
encukou Dec 16, 2025
3b3ae7c
Refcounting fix
encukou Dec 17, 2025
ff0f300
Style
encukou Dec 17, 2025
29f1690
Expand TODO
encukou Dec 17, 2025
d9728de
Remove comment that might be misleading
encukou Dec 17, 2025
0bc0198
PyUnicode_EqualToUTF8 can't error (and doesn't type-check)
encukou Dec 17, 2025
0ae6c58
Merge in the main branch
encukou Apr 8, 2026
619eac7
Use _DuringGC API in traversal functions
encukou Apr 8, 2026
d680b17
Don't clobber current exception in tp_dealloc
encukou Apr 8, 2026
38e5fea
Avoid data race in Xxo_setattro
encukou Apr 8, 2026
e6f10df
Merge in the main branch
encukou May 5, 2026
e2903da
Update xxlimited to PyCriticalSection
encukou May 5, 2026
330bb76
Update comment
encukou May 5, 2026
62f8b5b
Update C globals checker
encukou May 5, 2026
f08fac8
Address review comments
encukou May 7, 2026
f3bb5a1
Merge in the main branch
encukou May 7, 2026
5b0cd4f
Merge in the main branch
encukou May 8, 2026
c52a25a
Avoid warning
encukou May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review comments
  • Loading branch information
@encukou
encukou committed May 7, 2026
commit f08fac833563f03ec1fd02faafe1396a1e000329
5 changes: 3 additions & 2 deletions Modules/xxlimited.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,7 @@ xx_modexec(PyObject *m)
return -1;
}
if (PyModule_AddType(m, Str_Type) < 0) {
Py_DECREF(Str_Type);
return -1;

@vstinner vstinner May 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have to call Py_DECREF(Str_Type) here (on error)?

@encukou encukou May 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

}
Py_DECREF(Str_Type);
Expand Down Expand Up @@ -638,7 +639,7 @@ PyABIInfo_VAR(abi_info);
static PySlot xx_slots[] = {
/* Basic metadata */
PySlot_STATIC_DATA(Py_mod_name, "xxlimited"),
PySlot_STATIC_DATA(Py_mod_doc, (void*)module_doc),
PySlot_STATIC_DATA(Py_mod_doc, module_doc),
PySlot_DATA(Py_mod_abi, &abi_info),

/* The method table */
Expand All @@ -650,7 +651,7 @@ static PySlot xx_slots[] = {
PySlot_FUNC(Py_mod_exec, xx_modexec),

/* Module state and associated functions */
PySlot_SIZE(Py_mod_state_size, (void*)sizeof(xx_state)),
PySlot_SIZE(Py_mod_state_size, sizeof(xx_state)),
PySlot_FUNC(Py_mod_state_traverse, xx_traverse),
PySlot_FUNC(Py_mod_state_clear, xx_clear),
PySlot_FUNC(Py_mod_state_free, xx_free),
Expand Down