Visitar URL original
gh-78724: raise RuntimeError's when calling methods on non-ready Struct()'s by skirpichev · Pull Request #143643 · python/cpython · GitHub
Skip to content

gh-78724: raise RuntimeError's when calling methods on non-ready Struct()'s #143643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 14 commits into from
Jan 11, 2026
+31 −8
Merged

gh-78724: raise RuntimeError's when calling methods on non-ready Struct()'s #143643

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a1c2603
gh-143379: fix UAF in struct.Struct.pack() when object modified by du…
skirpichev Jan 3, 2026
716e28c
Merge branch 'master' into fix-uaf-s_pack_internal/143379
skirpichev Jan 10, 2026
e611953
address review: implement a different solution with a mutex flag
skirpichev Jan 10, 2026
ab62167
+ clean the mess
skirpichev Jan 10, 2026
3b18427
gh-78724: raise RuntimeError's when calling methods on non-ready Stru…
skirpichev Jan 10, 2026
54dbea8
Merge branch 'master' into deprecate-struct-init/78724
skirpichev Jan 10, 2026
b6c8bed
revert stuff from #143382
skirpichev Jan 10, 2026
f542173
revert deprecations (TBD: a separate pr)
skirpichev Jan 10, 2026
69a5eec
address review: redo patch to use s_codes
skirpichev Jan 10, 2026
0e6af95
Merge branch 'main' into deprecate-struct-init/78724
skirpichev Jan 10, 2026
8ba6b33
address review: -asserts + redo test
skirpichev Jan 10, 2026
ea0f8e2
address review: adjust tests
skirpichev Jan 10, 2026
c71be45
Merge branch 'master' into deprecate-struct-init/78724
skirpichev Jan 11, 2026
b61bddb
address review: revert unrelated change
skirpichev Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address review: revert unrelated change
  • Loading branch information
@skirpichev
skirpichev committed Jan 11, 2026
commit b61bddb41b82322ed3de8b4636c41312c5bbb8b5
8 changes: 4 additions & 4 deletions Modules/_struct.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1794,6 +1794,8 @@ static int
Struct___init___impl(PyStructObject *self, PyObject *format)
/*[clinic end generated code: output=b8e80862444e92d0 input=192a4575a3dde802]*/
{
int ret = 0;

if (PyUnicode_Check(format)) {
format = PyUnicode_AsASCIIString(format);
if (format == NULL)
Expand All @@ -1814,10 +1816,8 @@ Struct___init___impl(PyStructObject *self, PyObject *format)

Py_SETREF(self->s_format, format);

if (prepare_s(self)) {
return -1;
}
return 0;
ret = prepare_s(self);
return ret;
}

static int
Expand Down
Loading