Visitar URL original
[3.13] GH-91636: Clear weakrefs created by finalizers. (GH-136401) by sergey-miryanov · Pull Request #144214 · python/cpython · GitHub
Skip to content

[3.13] GH-91636: Clear weakrefs created by finalizers. (GH-136401) - #144214

Merged
ambv merged 4 commits into
python:3.13from
sergey-miryanov:backport-b6b99bf-3.13
Mar 23, 2026
Merged

[3.13] GH-91636: Clear weakrefs created by finalizers. (GH-136401)#144214
ambv merged 4 commits into
python:3.13from
sergey-miryanov:backport-b6b99bf-3.13

Conversation

@sergey-miryanov

@sergey-miryanov sergey-miryanov commented Jan 24, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Weakrefs to unreachable garbage that are created during running of finalizers need to be cleared. This avoids exposing objects that have tp_clear called on them to Python-level code. (cherry picked from commit b6b99bf)

@sergey-miryanov @nascheme
[3.13] pythonGH-91636: Clear weakrefs created by finalizers. (pythonG…
41fd1aa 
…H-136401)

Weakrefs to unreachable garbage that are created during running of
finalizers need to be cleared.  This avoids exposing objects that
have `tp_clear` called on them to Python-level code.
(cherry picked from commit b6b99bf)

Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
@bedevere-app bedevere-app Bot mentioned this pull request Jan 24, 2026
Closed
@bedevere-app bedevere-app Bot mentioned this pull request Jan 24, 2026
Merged
@gpshead

gpshead commented Jan 25, 2026

Copy link
Copy Markdown
Member

I think this needs re-applying to 3.14 if we're going to do it for 3.13. it was removed (likely temporarily) from 3.14 as a risk mitigation for 3.14.1 (see issue and prs)

@sergey-miryanov

sergey-miryanov commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

I understand. At least we have "working" PR for backporting if we decide so :)

StanFromIreland
StanFromIreland reviewed Feb 28, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-07-07-17-26-06.gh-issue-91636.GyHU72.rst
@gpshead gpshead mentioned this pull request Mar 5, 2026
Merged
@vstinner

vstinner commented Mar 10, 2026

Copy link
Copy Markdown
Member

I think this needs re-applying to 3.14 if we're going to do it for 3.13. it was removed (likely temporarily) from 3.14 as a risk mitigation for 3.14.1 (see issue and prs)

What's the status of this change? Did it land in 3.14 again or not?

@sergey-miryanov

sergey-miryanov commented Mar 12, 2026

Copy link
Copy Markdown
Contributor Author

@hugovk @Yhg1s Should we merge this since 3.14 backport was merged?

@vstinner

vstinner commented Mar 12, 2026

Copy link
Copy Markdown
Member

The 3.14 change is #144444?

@sergey-miryanov

sergey-miryanov commented Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

@vstinner Yes.

@ambv
ambv merged commit eda53e6 into python:3.13 Mar 23, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sergey-miryanov @gpshead @vstinner @StanFromIreland @ambv