Match else: to try:, and don't catch AttributeError

encukou · Sep 29, 2026 · Aug 14, 2026 · Aug 26, 2026 · Aug 28, 2026 · Sep 1, 2026
commit ffcf4bb3068c4cc67fa19e36f9983004bd037784
diff --git a/Lib/tempfile.py b/Lib/tempfile.py
@@ -323,14 +323,14 @@ def _resetperms_at(name, dir_fd, path):
         if _nofollow_mode is not None:
             try:
                 fd = _os.open(name, _nofollow_mode, dir_fd=dir_fd)
-            except (OSError, AttributeError):
+            except OSError:
                 pass
-        else:
-            try:
-                _os.chmod(fd, 0o700)
-            finally:
-                _os.close(fd)
-            return
+            else:
+                try:
+                    _os.chmod(fd, 0o700)
+                finally:
+                    _os.close(fd)
+                return
         # If that did not work, we change by name, which is subject to a race
         # condition.
         stat = _os.lstat(name, dir_fd=dir_fd)