Visitar URL original
gh-158592: Reallocate the list's array when deleting by index by x42005e1f · Pull Request #158602 · python/cpython · GitHub
Skip to content

gh-158592: Reallocate the list's array when deleting by index #158602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 6 commits into from
Oct 7, 2026
+2 −1
Merged

gh-158592: Reallocate the list's array when deleting by index #158602

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e7e439b
gh-158592: Reallocate the list's array when deleting by index
x42005e1f Oct 2, 2026
093ab9b
Add a NEWS entry
x42005e1f Oct 2, 2026
6f68a64
Apply the suggested change
x42005e1f Oct 3, 2026
fa0e380
Apply the suggested change (again)
x42005e1f Oct 5, 2026
9c8223e
Merge branch 'main' into gh-158592
corona10 Oct 6, 2026
ad8cdb7
Merge branch 'main' into gh-158592
corona10 Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-158592: Reallocate the list's array when deleting by index
  • Loading branch information
@x42005e1f
x42005e1f committed Oct 2, 2026
commit e7e439bd1dbc9fa5fea983358f7581c588045b73
2 changes: 1 addition & 1 deletion Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,7 @@ list_ass_item_lock_held(PyListObject *a, Py_ssize_t i, PyObject *v)
for (Py_ssize_t idx = i; idx < size - 1; idx++) {
FT_ATOMIC_STORE_PTR_RELEASE(a->ob_item[idx], a->ob_item[idx + 1]);
}
Py_SET_SIZE(a, size - 1);
list_resize(a, size - 1); // NB: shrinking a list can't fail
}
else {
FT_ATOMIC_STORE_PTR_RELEASE(a->ob_item[i], Py_NewRef(v));
Expand Down