Repository navigation
gh-158978: Fix cloning of DOM Level 1 nodes in xml.dom.minidom - #158987
Open
sricursion wants to merge 1 commit into
Open
sricursion wants to merge 1 commit into
sricursion wants to merge 1 commit into
Conversation
cloneNode() and importNode() created the clones with createElementNS(), setAttributeNS() and createAttributeNS(), which now reject a prefixed name in no namespace. Create the Element and Attr nodes directly instead.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.cloneNode()andDocument.importNode()raiseNamespaceErrfor DOM Level 1 nodes that have a colon in the name, for examplecreateElement("svg:rect"),setAttribute("xmlns:xsi", ...),createAttribute("a:b"), or any node of a document parsed with namespaces disabled._clone_node()rebuilt every element and attribute withcreateElementNS(),setAttributeNS()andcreateAttributeNS(), and since gh-156665 those reject a prefixed name in no namespace. The same applies tosetAttribute("xmlns", ...), which is rejected as thexmlnsattribute in the wrong namespace. This is a regression on the main branch only; 3.15 and earlier clone these nodes without error. The clones are now created directly withElementandAttr, the way the factory methods did before validation was added, so the clones of namespaced nodes are unchanged.There is no NEWS entry, since gh-156665 is not in any release yet.
xml.dom.minidom: cloneNode() and importNode() raise NamespaceErr for DOM Level 1 nodes #158978