Visitar URL original
bpo-40282: Allow random.getrandbits(0) by pitrou · Pull Request #19539 · python/cpython · GitHub
Skip to content

bpo-40282: Allow random.getrandbits(0) #19539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 7 commits into from
Apr 17, 2020
Merged

bpo-40282: Allow random.getrandbits(0) #19539

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f572b53
bpo-40282: Allow random.getrandbits(0)
pitrou Apr 15, 2020
3153f1a
Update Doc/library/random.rst
pitrou Apr 15, 2020
9cac35f
Ensure _randbelow implementations raise on 0 input.
pitrou Apr 15, 2020
b01be91
s/positive/non-negative/
pitrou Apr 15, 2020
e7c2e99
Revert changes to choice()
pitrou Apr 15, 2020
5e02ef8
Update Lib/test/test_random.py
pitrou Apr 15, 2020
c4673f0
Apply review comments
pitrou Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/test/test_random.py 
Co-Authored-By: Victor Stinner <vstinner@python.org>
  • Loading branch information
@pitrou @vstinner
pitrou and vstinner committed Apr 17, 2020
commit 5e02ef88b419e1942bddf47c33548524ddab01cc
3 changes: 2 additions & 1 deletion Lib/test/test_random.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,9 @@ def test_gauss(self):

def test_getrandbits(self):
# Verify ranges
for k in range(0, 1000):
for k in range(1, 1000):
self.assertTrue(0 <= self.gen.getrandbits(k) < 2**k)
self.assertEqual(self.gen.getrandbits(0), 0)

# Verify all bits active
getbits = self.gen.getrandbits
Expand Down