Visitar URL original
bpo-40286: Use random.randbytes() in tests by vstinner · Pull Request #19575 · python/cpython · GitHub
Skip to content

bpo-40286: Use random.randbytes() in tests #19575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Apr 17, 2020
Merged

bpo-40286: Use random.randbytes() in tests #19575

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9604f67
bpo-40286: Use random.randbytes() in tests
vstinner Apr 17, 2020
d2fed77
Remove genblock() of test_zlib: use randbytes()
vstinner Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove genblock() of test_zlib: use randbytes()
  • Loading branch information
@vstinner
vstinner committed Apr 17, 2020
commit d2fed77e42d73d760ee92be542cce428ae673eb1
17 changes: 1 addition & 16 deletions Lib/test/test_zlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ def test_odd_flush(self):
# others might simply have a single RNG
gen = random
gen.seed(1)
data = genblock(1, 17 * 1024, generator=gen)
data = gen.randbytes(17 * 1024)

# compress, sync-flush, and decompress
first = co.compress(data)
Expand Down Expand Up @@ -824,20 +824,6 @@ def test_wbits(self):
self.assertEqual(dco.decompress(gzip), HAMLET_SCENE)


def genblock(seed, length, step=1024, generator=random):
"""length-byte stream of random data from a seed (in step-byte blocks)."""
if seed is not None:
generator.seed(seed)
randint = generator.randint
if length < step or step < 2:
step = length
blocks = bytes()
for i in range(0, length, step):
blocks += bytes(randint(0, 255) for x in range(step))
return blocks



def choose_lines(source, number, seed=None, generator=random):
"""Return a list of number lines randomly chosen from the source"""
if seed is not None:
Expand All @@ -846,7 +832,6 @@ def choose_lines(source, number, seed=None, generator=random):
return [generator.choice(sources) for n in range(number)]



HAMLET_SCENE = b"""
LAERTES

Expand Down