Visitar URL original
bpo-29613: Added support for SameSite cookies by akash0x53 · Pull Request #214 · python/cpython · GitHub
Skip to content

bpo-29613: Added support for SameSite cookies #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akash0x53 wants to merge 8 commits into from
Closed

bpo-29613: Added support for SameSite cookies #214

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ef83909
bpo-29613: Added support for SameSite cookies
akash0x53 Feb 21, 2017
c8bc135
Documented SameSite
akash0x53 Feb 21, 2017
c064da4
Missing space :(
akash0x53 Feb 21, 2017
364ea46
Updated News and contributors
akash0x53 Feb 21, 2017
c3890a2
Added version changed details.
akash0x53 Feb 22, 2017
6ed3f3f
Fix in documentation
akash0x53 Feb 22, 2017
aa54e50
fix in documentation
akash0x53 Feb 22, 2017
a6cbc20
Clubbed test cases for same attribute into single.
akash0x53 Feb 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clubbed test cases for same attribute into single.
  • Loading branch information
@akash0x53
akash0x53 committed Feb 28, 2017
commit a6cbc20f3df0b09665ac213ce11b49026f06ebdc
19 changes: 8 additions & 11 deletions Lib/test/test_http_cookies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,14 @@ def test_set_secure_httponly_attrs(self):
self.assertEqual(C.output(),
'Set-Cookie: Customer="WILE_E_COYOTE"; HttpOnly; Secure')

def test_samesite_strict_attrs(self):
C = cookies.SimpleCookie('Customer="WILE_E_COYOTE"')
C['Customer']['samesite'] = "Strict"
self.assertEqual(C.output(),
'Set-Cookie: Customer="WILE_E_COYOTE"; SameSite=Strict')

def test_samesite_lax_attrs(self):
C = cookies.SimpleCookie('Customer="WILE_E_COYOTE"')
C['Customer']['samesite'] = "Lax"
self.assertEqual(C.output(),
'Set-Cookie: Customer="WILE_E_COYOTE"; SameSite=Lax')
def test_samesite_attrs(self):
samesite_values = ("Strict", "Lax")
for val in samesite_values:
with self.subTest(val=val):
C = cookies.SimpleCookie('Customer="WILE_E_COYOTE"')
C['Customer']['samesite'] = val
self.assertEqual(C.output(),
'Set-Cookie: Customer="WILE_E_COYOTE"; SameSite=%s' % val)

@timgraham timgraham Feb 22, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation missing

@akash0x53 akash0x53 Feb 25, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative. It just an illusion i guess. Perfectly showing in my vim.

@berkerpeksag berkerpeksag Feb 27, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Tim meant was that the second argument needs to be indented, like:

self.assertEqual(C.output(),
                 'Set-Cookie: Customer="WILE_E_COYOTE"; SameSite=%s' % val)

or even better:

expected = f'Set-Cookie: Customer="WILE_E_COYOTE"; SameSite={val}'
self.assertEqual(C.output(), expected)


def test_secure_httponly_false_if_not_present(self):
C = cookies.SimpleCookie()
Expand Down