Visitar URL original
bpo-42345: Fix three issues with typing.Literal parameters by uriyyo · Pull Request #23294 · python/cpython · GitHub
Skip to content

bpo-42345: Fix three issues with typing.Literal parameters #23294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 8 commits into from
Nov 17, 2020
Merged

bpo-42345: Fix three issues with typing.Literal parameters #23294

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
03637e2
bpo-42345: Literal equality no longer depends on order of arguments
uriyyo Nov 15, 2020
4fbf590
Use value and type for Literal equality check
uriyyo Nov 15, 2020
ea06129
Return Literal equality test
uriyyo Nov 15, 2020
b8a597a
Use typed lru_cache for Literal type
uriyyo Nov 15, 2020
19b0952
Update Misc/NEWS
uriyyo Nov 15, 2020
9d2187a
Update signature of _tp_cache function
uriyyo Nov 16, 2020
942dece
Add Literal arguments deduplication
uriyyo Nov 16, 2020
f653d68
Update News. Add tests for Literal.__args__
uriyyo Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update signature of _tp_cache function
  • Loading branch information
@uriyyo
uriyyo committed Nov 16, 2020
commit 9d2187a907f6d3e023ca946dde59bf0a1ceafb20
6 changes: 3 additions & 3 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,12 @@ def _flatten_literal_params(parameters):
_cleanups = []


def _tp_cache(typed=False):
def _tp_cache(func=None, /, *, typed=False):
"""Internal wrapper caching __getitem__ of generic types with a fallback to
original function for non-hashable arguments.
Comment thread
uriyyo marked this conversation as resolved.
"""
if callable(typed):
return _tp_cache()(typed)
if func is not None:
return _tp_cache(typed=typed)(func)
Comment thread
uriyyo marked this conversation as resolved.
Outdated

def decorator(func):
cached = functools.lru_cache(typed=typed)(func)
Expand Down
3 changes: 2 additions & 1 deletion Misc/NEWS.d/next/Library/2020-11-15-15-23-34.bpo-42345.hiIR7x.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
Fix ``typing.Literal`` equals method to ignore the order of arguments.
Patch provided by Yurii Karabas.
Fix issue related to ``typing.Literal`` caching by adding ``typed``
parameter to ``typing._tp_cache`` function. Patch provided by Yurii Karabas.