Visitar URL original
bpo-43012: remove `pathlib._Accessor` by barneygale · Pull Request #25701 · python/cpython · GitHub
Skip to content

bpo-43012: remove pathlib._Accessor #25701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 15 commits into from
Feb 2, 2022
+78 −130
Merged

bpo-43012: remove pathlib._Accessor #25701

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7d33921
Call `accessor.getcwd()` from only one method.
barneygale Apr 28, 2021
740953b
Call `accessor.stat()` from only one method.
barneygale Apr 28, 2021
57f40f7
Call `accessor.scandir()` from only one method.
barneygale Apr 28, 2021
f3855f8
Call `accessor.link()` from only one method.
barneygale Apr 28, 2021
734940f
Delete `pathlib._Accessor`.
barneygale Apr 28, 2021
3dfefdf
Fix broken `test_glob_permissions` test.
barneygale Apr 28, 2021
613a171
Rename `Path.scandir()` to `Path._scandir()`
barneygale May 13, 2021
d07f465
Simplify handling of missing `os.readlink()`, `symlink()` and `link()`.
barneygale May 14, 2021
013ddc6
Add comment explaining why we access the filesystem via `Path` object…
barneygale Jan 5, 2022
c9ffcf9
Move comment to `Path._scandir()` definition.
barneygale Jan 5, 2022
3783a6a
Add news entry
barneygale Jan 5, 2022
8aabc5d
Undo changes to selector classes.
barneygale Jan 9, 2022
d3c363b
Merge branch 'main' into bpo-43012-remove-pathlib-accessor
barneygale Jan 20, 2022
37d5127
Merge branch 'main' into bpo-43012-remove-pathlib-accessor
barneygale Jan 29, 2022
cfaf15f
Fix up broken merge from main.
barneygale Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move comment to Path._scandir() definition.
  • Loading branch information
@barneygale
barneygale committed Jan 5, 2022
commit c9ffcf90d855e2aaf389ee889c72d797c41a629e
7 changes: 3 additions & 4 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,6 @@ def __init__(self, pat, child_parts, flavour):

def _select_from(self, parent_path, is_dir, exists):
try:
# bpo-24132: a future version of pathlib will support subclassing
# of pathlib.Path to customize how the filesystem is accessed. We
# must honour those customizations here, rather than calling
# os.scandir() directly.
with parent_path._scandir() as scandir_it:
Comment thread
barneygale marked this conversation as resolved.
Outdated
entries = list(scandir_it)
for entry in entries:
Expand Down Expand Up @@ -934,6 +930,9 @@ def iterdir(self):
yield self._make_child_relpath(name)

def _scandir(self):
# bpo-24132: a future version of pathlib will support subclassing of
# pathlib.Path to customize how the filesystem is accessed. This
# includes scandir(), which is used to implement glob().
return os.scandir(self)

def glob(self, pattern):
Expand Down