Visitar URL original
bpo-44554: refactor pdb targets (and internal tweaks) by jaraco · Pull Request #26992 · python/cpython · GitHub
Skip to content

bpo-44554: refactor pdb targets (and internal tweaks) #26992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 14 commits into from
Jul 19, 2021
Merged

bpo-44554: refactor pdb targets (and internal tweaks) #26992

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
59b5906
Refactor module/script handling to share an interface (check method).
jaraco Jul 2, 2021
4df7611
Import functools and adjust tests for the new line number for find_fu…
jaraco Jul 2, 2021
86fbc39
Use cached_property for details.
jaraco Jul 2, 2021
825e35b
Add blurb.
jaraco Jul 2, 2021
914ec41
Add comments about 'orig'
jaraco Jul 2, 2021
b959e3e
Rely on singledispatch to dispatch the target.
jaraco Jul 2, 2021
4fdd84e
Ignore ModuleTarget in test_pyclbr. It trips up on the cached property.
jaraco Jul 2, 2021
9dfbe0c
Update blurb to reflect more than a refactor.
jaraco Jul 2, 2021
415ea29
Rename news to reference bpo-44554.
jaraco Jul 2, 2021
0d0bd5c
Add blurb
jaraco Jul 2, 2021
e21f085
Simplify changelog per suggestion.
jaraco Jul 18, 2021
fe8aea5
Replace singledispatch _run with a unified implementation selecting o…
jaraco Jul 18, 2021
0d8611c
Suppress spurious errors in pyclbr when it encounters properties and …
jaraco Jul 18, 2021
c91ba80
Make _spec and _details private.
jaraco Jul 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use cached_property for details.
  • Loading branch information
@jaraco
jaraco committed Jul 2, 2021
commit 86fbc39159a5793a763c8b1a45cebac4636027d9
12 changes: 5 additions & 7 deletions Lib/pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1544,7 +1544,7 @@ def _run(self, target):
def _runmodule(self, target: 'ModuleTarget'):
self._wait_for_mainpyfile = True
self._user_requested_quit = False
mod_name, mod_spec, code = target.module_details
mod_name, mod_spec, code = target.details
self.mainpyfile = self.canonic(code.co_filename)
import __main__
__main__.__dict__.clear()
Expand Down Expand Up @@ -1691,12 +1691,10 @@ class ModuleTarget(str):
def check(self):
pass

@property
def module_details(self):
if not hasattr(self, '_details'):
import runpy
self._details = runpy._get_module_details(self)
return self._details
@functools.cached_property
def details(self):
import runpy
return runpy._get_module_details(self)


def main():
Expand Down