Visitar URL original
[3.10] bpo-27513: email.utils.getaddresses() now handles Header objects (GH-13797) by miss-islington · Pull Request #27242 · python/cpython · GitHub
Skip to content

[3.10] bpo-27513: email.utils.getaddresses() now handles Header objects (GH-13797) #27242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 1 commit into from
Jul 19, 2021
Merged

[3.10] bpo-27513: email.utils.getaddresses() now handles Header objects (GH-13797) #27242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-27513: email.utils.getaddresses() now handles Header objects (GH-… 
…13797)

getaddresses() should be able to handle a Header object if passed
one.

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 89f4c34)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
  • Loading branch information
@ZackerySpytz @miss-islington
ZackerySpytz authored and miss-islington committed Jul 19, 2021
commit ff346cc9ff7239805d52f522a27fe8bf255ddfac
2 changes: 1 addition & 1 deletion Lib/email/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def formataddr(pair, charset='utf-8'):

def getaddresses(fieldvalues):
"""Return a list of (REALNAME, EMAIL) for each fieldvalue."""
all = COMMASPACE.join(fieldvalues)
all = COMMASPACE.join(str(v) for v in fieldvalues)
a = _AddressList(all)
return a.addresslist

Expand Down
5 changes: 5 additions & 0 deletions Lib/test/test_email/test_email.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3263,6 +3263,11 @@ def test_getaddresses_embedded_comment(self):
addrs = utils.getaddresses(['User ((nested comment)) <foo@bar.com>'])
eq(addrs[0][1], 'foo@bar.com')

def test_getaddresses_header_obj(self):
"""Test the handling of a Header object."""
addrs = utils.getaddresses([Header('Al Person <aperson@dom.ain>')])
self.assertEqual(addrs[0][1], 'aperson@dom.ain')

def test_make_msgid_collisions(self):
# Test make_msgid uniqueness, even with multiple threads
class MsgidsThread(Thread):
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2019-06-03-23-53-25.bpo-27513.qITN7d.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
:func:`email.utils.getaddresses` now accepts
:class:`email.header.Header` objects along with string values.
Patch by Zackery Spytz.