Visitar URL original
bpo-44839: Raise more specific errors in sqlite3 by serhiy-storchaka · Pull Request #27613 · python/cpython · GitHub
Skip to content

bpo-44839: Raise more specific errors in sqlite3 - #27613

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:sqlite-python-to-sqlite-errors
Aug 6, 2021
Merged

bpo-44839: Raise more specific errors in sqlite3#27613
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:sqlite-python-to-sqlite-errors

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 5, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

MemoryError raised in user-defined function will now preserve
its type. OverflowError will now be converted to DataError.
Previously both were converted to OperationalError.

https://bugs.python.org/issue44839

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Aug 5, 2021
@serhiy-storchaka
bpo-44839: Raise more specific errors in sqlite3
d7fba66 
MemoryError raised in user-defined function will now preserve
its type. OverflowError will now be converted to DataError.
Previously both were converted to OperationalError.
@serhiy-storchaka
serhiy-storchaka force-pushed the sqlite-python-to-sqlite-errors branch from 99def7f to d7fba66 Compare August 5, 2021 12:07
@erlend-aasland erlend-aasland mentioned this pull request Aug 6, 2021
Merged
erlend-aasland
erlend-aasland requested changes Aug 6, 2021
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor adjustments. This is a nice refactoring. These changes will greatly simplify GH-27456. Thanks!

Comment thread Misc/NEWS.d/next/Library/2021-08-05-14-59-39.bpo-44839.MURNL9.rst Outdated
Comment thread Modules/_sqlite/connection.c Outdated
Comment thread Modules/_sqlite/connection.c Outdated
serhiy-storchaka
serhiy-storchaka commented Aug 6, 2021
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review. It is always good to have a second pair of eyes.

Comment thread Modules/_sqlite/connection.c Outdated
Comment thread Modules/_sqlite/connection.c Outdated
erlend-aasland
erlend-aasland reviewed Aug 6, 2021
View reviewed changes
Comment thread Modules/_sqlite/connection.c Outdated
erlend-aasland
erlend-aasland approved these changes Aug 6, 2021
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@serhiy-storchaka Erlend Egeberg Aasland
Update Modules/_sqlite/connection.c
4de7af8 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@serhiy-storchaka
serhiy-storchaka merged commit 7d747f2 into python:main Aug 6, 2021
@serhiy-storchaka
serhiy-storchaka deleted the sqlite-python-to-sqlite-errors branch August 6, 2021 18:28
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jan 30, 2022
Erlend E. Aasland
Fix test_func_return_too_large_int
28de39f 
pythonGH-27613 (bpo 44839) was not backported, so exceptions differ between
main (3.11) and older versions.
@erlend-aasland erlend-aasland mentioned this pull request Jan 30, 2022
Merged
JelleZijlstra pushed a commit that referenced this pull request Feb 21, 2022
Erlend Egeberg Aasland
[3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-3…
ba457fe 
…1030)

* [3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642).
(cherry picked from commit 3eb3b4f)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

* Fix test_func_return_too_large_int

GH-27613 (bpo 44839) was not backported, so exceptions differ between
main (3.11) and older versions.
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @erlend-aasland @the-knights-who-say-ni @bedevere-bot