Raise ProgrammingError if limit is out of bounds

pablogsal · Nov 1, 2021 · Sep 19, 2021 · Sep 19, 2021 · Sep 19, 2021 · Sep 19, 2021
commit e093a993244c8d41850b2cace576f61c17b9e882
diff --git a/Lib/sqlite3/test/test_dbapi.py b/Lib/sqlite3/test/test_dbapi.py
@@ -360,6 +360,12 @@ def test_connection_limits(self):
         finally:  # restore old limit
             self.cx.setlimit(param, ret1)
 
+    def test_connection_set_bad_limit(self):
+        self.assertRaisesRegex(
+            sqlite.ProgrammingError, "'limit' is out of bounds",
+            self.cx.setlimit, 1111, 0
+        )
+
 
 class UninitialisedConnectionTests(unittest.TestCase):
     def setUp(self):

@@ -1892,6 +1892,10 @@ setlimit_impl(pysqlite_Connection *self, int limit, int value)
     }
 
     int previous_value = sqlite3_limit(self->db, limit, value);
+    if (previous_value < 0) {
+        PyErr_SetString(self->ProgrammingError, "'limit' is out of bounds");
+        return NULL;
+    }
     return PyLong_FromLong(previous_value);
 }