Visitar URL original
bpo-41682: skip `test_sendfile_close_peer_in_the_middle_of_receiving` in `test_asyncio` by sobolevn · Pull Request #30801 · python/cpython · GitHub
Skip to content

bpo-41682: skip test_sendfile_close_peer_in_the_middle_of_receiving in test_asyncio #30801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 3 commits into from
Jan 22, 2022
Merged

bpo-41682: skip test_sendfile_close_peer_in_the_middle_of_receiving in test_asyncio #30801

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
daa6df1
bpo-41682: skip `test_sendfile_close_peer_in_the_middle_of_receiving`…
sobolevn Jan 22, 2022
688b13a
Update test_sendfile.py
sobolevn Jan 22, 2022
3562150
Update Lib/test/test_asyncio/test_sendfile.py
sobolevn Jan 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update Lib/test/test_asyncio/test_sendfile.py
  • Loading branch information
@sobolevn
sobolevn authored Jan 22, 2022
commit 3562150158a10542dca6b2e46bb2210774c86224
2 changes: 1 addition & 1 deletion Lib/test/test_asyncio/test_sendfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ def test_sendfile_ssl_close_peer_after_receiving(self):
@unittest.skipIf(sys.platform.startswith('sunos'),
"Doesn't work on Solaris")
@unittest.skipIf(sys.platform == "win32",
"It is flaky on win and needs to be fixed") # TODO: bpo-41682
"It is flaky on Windows and needs to be fixed") # TODO: bpo-41682

@jaraco jaraco Jan 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: I'd probably include the bug number in the skip message in case that's all the viewer sees.

@vstinner vstinner Jan 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to not include it in the skip message. Otherwise, https://bugs.python.org/issue41682 will be spammed with pull requests unrelated to the change, if a CI job fails with this message. The bot which mentions PR in bpo searchs for "bpo-xxx" anyway in a PR :-(

@erlend-aasland erlend-aasland Jan 22, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch!

def test_sendfile_close_peer_in_the_middle_of_receiving(self):
srv_proto, cli_proto = self.prepare_sendfile(close_after=1024)
with self.assertRaises(ConnectionError):
Expand Down