Visitar URL original
gh-68320, gh-88302 - Allow for `pathlib.Path` subclassing by barneygale · Pull Request #31691 · python/cpython · GitHub
Skip to content

gh-68320, gh-88302 - Allow for pathlib.Path subclassing #31691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 53 commits into from
Dec 23, 2022
Merged

gh-68320, gh-88302 - Allow for pathlib.Path subclassing #31691

Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
7371220
bpo-24132, bpo-44136 - Fix `pathlib.Path` subclassing.
barneygale Mar 5, 2022
8431d12
Add tests
barneygale Mar 5, 2022
bf2ad3a
Add tests for PurePath subclasses
barneygale Mar 5, 2022
4036e2e
Update Misc/NEWS.d/next/Library/2022-03-05-02-14-09.bpo-24132.W6iORO.rst
barneygale Mar 5, 2022
0d08533
Rename `PurePath._pathmod` to `PurePath._flavour` to reduce the diff.
barneygale Mar 5, 2022
0ad8022
Merge branch 'bpo-44136-remove-pathlib-flavour-2' of github.com:barne…
barneygale Mar 5, 2022
28992fc
Undo an unnecessary change to `Path.__new__()`
barneygale Mar 25, 2022
dbec230
Remove `_casefold()` and `_casefold_parts()` methods.
barneygale Mar 25, 2022
d814ee4
Merge branch 'main' into bpo-44136-remove-pathlib-flavour-2
barneygale Apr 29, 2022
63f1d68
Further simplify overall diff by inlining code from `compile_pattern()`
barneygale Apr 29, 2022
8dddfdf
Apply suggestions from code review
barneygale Apr 29, 2022
b4da721
Address a couple bits of review feedback
barneygale Apr 29, 2022
7a166fd
Fix tests
barneygale Apr 29, 2022
1f4dff1
Fix docstring formatting.
barneygale Apr 29, 2022
51893c1
Remove FIXME comments
barneygale Apr 30, 2022
48b49b6
Merge branch 'main' into bpo-44136-remove-pathlib-flavour-2
barneygale Apr 30, 2022
3624c97
Update Lib/pathlib.py
barneygale May 3, 2022
ab54c14
Remove vestigal 'casefold' names.
barneygale May 31, 2022
2627417
Merge branch 'main' into bpo-44136-remove-pathlib-flavour-2
barneygale Jun 10, 2022
bc7aded
Restore comment on POSIX paths beginning `//` and tweak implementation.
barneygale Jun 10, 2022
4d6e4f3
Inline `_join_parsed_parts()` and `_make_child()` in `joinpath()`.
barneygale Jun 12, 2022
70ca838
Update Lib/pathlib.py
barneygale Jun 13, 2022
a2cc74f
Remove unused import
barneygale Jun 16, 2022
0e2478b
Make NEWS entry more precise.
barneygale Jun 17, 2022
0d0cf60
Apply suggestions from code review
barneygale Jul 29, 2022
f3048d3
Clarify `_pparts` and `_ncparts` naming.
barneygale Jul 29, 2022
8a213ae
Tidy up usage of `normcase()`
barneygale Jul 30, 2022
402dafe
Tweak `is_absolute()` to use `os.path.isabs()` wherever possible.
barneygale Jul 30, 2022
5cc3ab2
Stop using `self._flavour` in `as_uri()`.
barneygale Jul 30, 2022
19a8804
Remove `cls._flavour` identity check in `_parse_parts()`.
barneygale Jul 30, 2022
9da46bc
Fix Windows tests
barneygale Jul 30, 2022
29f9f81
Restore `_split_root()` method and its tests.
barneygale Aug 1, 2022
52851b8
Merge branch 'main' into bpo-44136-remove-pathlib-flavour-2
barneygale Aug 5, 2022
b39da53
Optimize `_split_root()`
barneygale Aug 12, 2022
c7b18b1
Merge branch 'main' into bpo-44136-remove-pathlib-flavour-2
barneygale Aug 13, 2022
806ad15
Move `is_reserved()` implementation into `os.path` as a private funct…
barneygale Aug 23, 2022
a350009
Use `os.path.normcase()` when globbing.
barneygale Aug 23, 2022
799b40e
Simplify `_split_root()` implementation.
barneygale Aug 25, 2022
a6b25ea
Remove tests for malformed UNC paths
barneygale Aug 26, 2022
ac6f6e2
Merge branch 'main' into bpo-44136-remove-pathlib-flavour-2
brettcannon Aug 26, 2022
b8874df
Revert "Move `is_reserved()` implementation into `os.path` as a priva…
barneygale Aug 27, 2022
9d5e18a
Tweak _split_root() to use removesuffix()
barneygale Aug 27, 2022
f73f426
Remove test that `/b/c/d` and `///b/c/d` are equivalent.
barneygale Aug 27, 2022
37e4bc1
Restore comment linking to *Naming Files* page in Microsoft docs
barneygale Sep 16, 2022
e3f13ef
Apply suggestions from code review
barneygale Nov 7, 2022
ff4e1b3
Merge branch 'main' into bpo-44136-remove-pathlib-flavour-2
barneygale Nov 15, 2022
07c67d0
Clarify repr roundtrip tests.
barneygale Nov 15, 2022
950aa47
Reduce tests diff
barneygale Nov 15, 2022
d5f6f03
Remove test that `/b/c/d` and `///b/c/d` are equivalent.
barneygale Aug 27, 2022
b66a4fb
Fix missing full stops.
barneygale Nov 15, 2022
fbaadf4
Remove four more test assertions affected by #96290
barneygale Nov 15, 2022
3692fdf
Merge branch 'main' into bpo-44136-remove-pathlib-flavour-2
barneygale Nov 25, 2022
40dc514
Wrap repr test cases in `self.subTest()` block
barneygale Dec 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Brett Cannon <brett@python.org>
  • Loading branch information
@barneygale @brettcannon
barneygale and brettcannon authored Apr 29, 2022
commit 8dddfdf995791e1cc081078cb73b79f2f35488f9
4 changes: 2 additions & 2 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#

_WIN_EXT_NAMESPACE_PREFIX = '\\\\?\\'
Comment thread
barneygale marked this conversation as resolved.
Outdated
_WIN_DRIVE_LETTERS = set('abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ')
_WIN_DRIVE_LETTERS = frozenset(string.ascii_letters)
_WIN_RESERVED_NAMES = (
Comment thread
barneygale marked this conversation as resolved.
Outdated
{'CON', 'PRN', 'AUX', 'NUL', 'CONIN$', 'CONOUT$'} |
{'COM%s' % c for c in '123456789\xb9\xb2\xb3'} |
Expand Down Expand Up @@ -301,7 +301,7 @@ def _splitroot(cls, part):
else:
prefix = ''
third = part[2:3]
Comment thread
barneygale marked this conversation as resolved.
Outdated
Comment thread
barneygale marked this conversation as resolved.
Outdated
if (second == sep and first == sep and third != sep):
if second == sep and first == sep and third != sep:
# is a UNC path:
Comment thread
barneygale marked this conversation as resolved.
Outdated
# vvvvvvvvvvvvvvvvvvvvv root
# \\machine\mountpoint\directory\etc\...
Expand Down