Visitar URL original
gh-88050: Fix asyncio subprocess kill process cleanly when process is blocked by kumaraditya303 · Pull Request #32073 · python/cpython · GitHub
Skip to content

gh-88050: Fix asyncio subprocess kill process cleanly when process is blocked #32073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 25 commits into from
Oct 5, 2022
Merged

gh-88050: Fix asyncio subprocess kill process cleanly when process is blocked #32073

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
485b26b
bpo-43884: Fix asyncio subprocess kill process cleanly when process i…
kumaraditya303 Mar 23, 2022
7c10817
Merge branch 'main' of https://github.com/python/cpython into fix-asy…
kumaraditya303 Mar 24, 2022
0b87f8d
rework
kumaraditya303 Mar 24, 2022
2bd08cf
start from scratch
kumaraditya303 Mar 28, 2022
6afa6df
Merge branch 'main' of https://github.com/python/cpython into fix-asy…
kumaraditya303 Mar 28, 2022
a2a3a1d
rework
kumaraditya303 Mar 28, 2022
e325b6c
remove script
kumaraditya303 Mar 28, 2022
6a37501
Merge branch 'main' into fix-asyncio-subprocess
kumaraditya303 Apr 17, 2022
5fa81d6
Merge branch 'main' into fix-asyncio-subprocess
kumaraditya303 May 4, 2022
74e42a7
Merge branch 'main' into fix-asyncio-subprocess
kumaraditya303 May 27, 2022
7946267
another try
kumaraditya303 May 27, 2022
4f18b7d
Merge branch 'main' into fix-asyncio-subprocess
kumaraditya303 Jul 7, 2022
d896e0b
skip unless sleep
kumaraditya303 Jul 8, 2022
b5de374
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 8, 2022
727bb9e
Merge branch 'main' into fix-asyncio-subprocess
kumaraditya303 Jul 21, 2022
e7eca7a
Merge branch 'main' into fix-asyncio-subprocess
kumaraditya303 Sep 12, 2022
8b2cee6
fix test on windows
kumaraditya303 Oct 1, 2022
53fbc9a
fix comment
kumaraditya303 Oct 1, 2022
77c76dd
Merge branch 'main' of https://github.com/python/cpython into fix-asy…
kumaraditya303 Oct 1, 2022
e223141
Update Misc/NEWS.d/next/Library/2022-07-08-08-39-35.gh-issue-88050.0a…
kumaraditya303 Oct 5, 2022
4ac1184
Merge branch 'main' into fix-asyncio-subprocess
kumaraditya303 Oct 5, 2022
69a9fda
fixup test as Guido suggested
kumaraditya303 Oct 5, 2022
678cc76
Merge branch 'main' into fix-asyncio-subprocess
kumaraditya303 Oct 5, 2022
ba0382d
fix killing on windows
kumaraditya303 Oct 5, 2022
90e7ac5
Merge branch 'fix-asyncio-subprocess' of https://github.com/kumaradit…
kumaraditya303 Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
skip unless sleep
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Jul 8, 2022
commit d896e0bb2e7d4d3b9fedff1828667caa375de2ce
4 changes: 3 additions & 1 deletion Lib/test/test_asyncio/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
import shutil
import signal
import sys
import unittest
Expand Down Expand Up @@ -184,8 +185,9 @@ def test_kill(self):
else:
self.assertEqual(-signal.SIGKILL, returncode)

@unittest.skipUnless(shutil.which('sleep'), 'sleep is not available')
def test_kill_issue43884(self):
blocking_shell_command = f'{sys.executable} -c "import time; time.sleep(10000)"'
blocking_shell_command = 'sleep 10000'
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated
proc = self.loop.run_until_complete(
asyncio.create_subprocess_shell(blocking_shell_command, stdout=asyncio.subprocess.PIPE)
)
Expand Down