Visitar URL original
gh-91372: add mtime to gzip.open by ellaellela · Pull Request #32310 · python/cpython · GitHub
Skip to content

gh-91372: add mtime to gzip.open #32310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 16 commits into from
May 22, 2026
Merged

gh-91372: add mtime to gzip.open #32310

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
925a9bf
add mtime to gzip.open
ellaellela Apr 4, 2022
7372cb5
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 4, 2022
5801343
Merge branch 'main' into add-mtime-to-gzip-open
AlexWaygood Feb 23, 2024
093eeca
Merge branch 'python:main' into add-mtime-to-gzip-open
ellaellela Mar 30, 2024
4eb8678
update docs for adding mtime to gzip open and add reviews
ellaellela Mar 30, 2024
44e6626
Merge branch 'main' into add-mtime-to-gzip-open
ellaellela May 22, 2026
389ccde
Update 3.16.rst
ellaellela May 22, 2026
bb1b4b5
Update 3.16.rst formating
ellaellela May 22, 2026
a92c1c7
Update 3.16.rst formating
ellaellela May 22, 2026
eadd8b9
Merge branch 'main' into add-mtime-to-gzip-open
ellaellela May 22, 2026
e121a63
update Misc/NEWS.d/next/Library/2022-04-04-17-58-05.bpo-47216.gPyPte.rst
ellaellela May 22, 2026
b9bffb5
Update according to review requests.
ellaellela May 22, 2026
18af009
Apply suggestions from code review
ellaellela May 22, 2026
ab6ba39
Reviewer's doc improvements.
ellaellela May 22, 2026
33d07f4
Reviewer's improvements.
ellaellela May 22, 2026
962e598
Merge branch 'main' into add-mtime-to-gzip-open
ellaellela May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add mtime to gzip.open
  • Loading branch information
@ellaellela
ellaellela committed Apr 4, 2022
commit 925a9bf6e6e01cc80a87a584a0b7cc7c6a07b17a
6 changes: 3 additions & 3 deletions Lib/gzip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@


def open(filename, mode="rb", compresslevel=_COMPRESS_LEVEL_BEST,
encoding=None, errors=None, newline=None):
encoding=None, errors=None, newline=None, mtime=None):
Comment thread
ellaellela marked this conversation as resolved.
Outdated
"""Open a gzip-compressed file in binary or text mode.

The filename argument can be an actual filename (a str or bytes object), or
Expand Down Expand Up @@ -55,9 +55,9 @@ def open(filename, mode="rb", compresslevel=_COMPRESS_LEVEL_BEST,

gz_mode = mode.replace("t", "")
if isinstance(filename, (str, bytes, os.PathLike)):
binary_file = GzipFile(filename, gz_mode, compresslevel)
binary_file = GzipFile(filename, gz_mode, compresslevel, mtime=mtime)
elif hasattr(filename, "read") or hasattr(filename, "write"):
binary_file = GzipFile(None, gz_mode, compresslevel, filename)
binary_file = GzipFile(None, gz_mode, compresslevel, filename, mtime=mtime)
Comment thread
ellaellela marked this conversation as resolved.
Outdated
else:
raise TypeError("filename must be a str or bytes object, or a file")

Expand Down
11 changes: 11 additions & 0 deletions Lib/test/test_gzip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,17 @@ def test_mtime(self):
self.assertEqual(dataRead, data1)
self.assertEqual(fRead.mtime, mtime)

def test_mtime_with_open(self):
mtime = 123456789
with gzip.open(self.filename, "w", mtime = mtime) as fWrite:
Comment thread
ellaellela marked this conversation as resolved.
Outdated
fWrite.write(data1)
with gzip.open(self.filename, "rb") as fRead:
self.assertTrue(hasattr(fRead, 'mtime'))
self.assertIsNone(fRead.mtime)
dataRead = fRead.read()
self.assertEqual(dataRead, data1)
self.assertEqual(fRead.mtime, mtime)

def test_metadata(self):
mtime = 123456789

Expand Down