Visitar URL original
bpo-9303: Migrate sqlite3 module to _v2 API to enhance performance by palaviv · Pull Request #359 · python/cpython · GitHub
Skip to content

bpo-9303: Migrate sqlite3 module to _v2 API to enhance performance #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berkerpeksag merged 10 commits into from
Mar 3, 2017
Merged

bpo-9303: Migrate sqlite3 module to _v2 API to enhance performance #359

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c92e604
Add optional use of sqlite3_open_v2, sqlite3_close_v2 and sqlite3_pre…
palaviv Feb 28, 2017
8eccb84
Use SQLITE_VERSION_NUMBER
palaviv Mar 1, 2017
5360795
Don't call sqlite3_reset in _pysqlite_seterror in using sqlite3_prepa…
palaviv Mar 1, 2017
9185cb9
Revert sqlite3_open change
palaviv Mar 1, 2017
f7dcd02
Don't reset the statment if using sqlite3_prepare_v2
palaviv Mar 2, 2017
d4d9c4e
CR fixes
palaviv Mar 2, 2017
64c3bb7
Add NEWS entry
palaviv Mar 2, 2017
645d959
Merge remote-tracking branch 'upstream/master' into sqlite-v2-api
palaviv Mar 2, 2017
f1ddaba
Fix ifdef in _pysqlite_seterror
palaviv Mar 3, 2017
3157f4c
Merge remote-tracking branch 'upstream/master' into sqlite-v2-api
palaviv Mar 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't call sqlite3_reset in _pysqlite_seterror in using sqlite3_prepa… 
…re_v2
  • Loading branch information
@palaviv
palaviv committed Mar 1, 2017
commit 53607957972adb504efb80abda699e4ef8314814
6 changes: 5 additions & 1 deletion Modules/_sqlite/util.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,14 @@ int _pysqlite_seterror(sqlite3* db, sqlite3_stmt* st)
{
int errorcode;

/* SQLite often doesn't report anything useful, unless you reset the statement first */
#if SQLITE_VERSION_NUMBER >= 3003009

@berkerpeksag berkerpeksag Mar 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't >= be < here?

@serhiy-storchaka serhiy-storchaka Mar 3, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@palaviv palaviv Mar 3, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

/* SQLite often doesn't report anything useful, unless you reset the statement first.
When using sqlite3_prepare_v2 this is not needed. */
if (st != NULL) {
(void)sqlite3_reset(st);
}
#endif

@berkerpeksag berkerpeksag Mar 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Please remove extra empty line.

@palaviv palaviv Mar 2, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


errorcode = sqlite3_errcode(db);

Expand Down