Visitar URL original
bpo-28728: clarify possible test failure due to ISP by zhangyangyu · Pull Request #412 · python/cpython · GitHub
Skip to content

bpo-28728: clarify possible test failure due to ISP #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhangyangyu merged 2 commits into from
Mar 7, 2017
Merged

bpo-28728: clarify possible test failure due to ISP #412

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27dce48
clarify possible test failure due to ISP
zhangyangyu Mar 3, 2017
17ba2c6
replace \ with ()
zhangyangyu Mar 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,11 +803,6 @@ def testHostnameRes(self):
self.fail("Error testing host resolution mechanisms. (fqdn: %s, all: %s)" % (fqhn, repr(all_host_names)))

def test_host_resolution(self):
for addr in ['0.1.1.~1', '1+.1.1.1', '::1q', '::1::2',
'1:1:1:1:1:1:1:1:1']:
self.assertRaises(OSError, socket.gethostbyname, addr)
self.assertRaises(OSError, socket.gethostbyaddr, addr)

for addr in [support.HOST, '10.0.0.1', '255.255.255.255']:
self.assertEqual(socket.gethostbyname(addr), addr)

Expand All @@ -816,6 +811,19 @@ def test_host_resolution(self):
for host in [support.HOST]:
self.assertIn(host, socket.gethostbyaddr(host)[2])

def test_host_resolution_bad_address(self):
# These are all malformed IP addresses and expected not to resolve to
# any result. But some ISPs, e.g. AWS, may successfully resolve these
# IPs.
explanation = "resolving an invalid IP address did not raise OSError; " \

@berkerpeksag berkerpeksag Mar 3, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use \ here:

msg = (
    "resolving an invalid IP address did not raise OSError; "
    "can be caused by a broken DNS server"
)

"can be caused by a broken DNS server"
for addr in ['0.1.1.~1', '1+.1.1.1', '::1q', '::1::2',
'1:1:1:1:1:1:1:1:1']:
with self.assertRaises(OSError):
socket.gethostbyname(addr)
with self.assertRaises(OSError, msg=explanation):
socket.gethostbyaddr(addr)

@unittest.skipUnless(hasattr(socket, 'sethostname'), "test needs socket.sethostname()")
@unittest.skipUnless(hasattr(socket, 'gethostname'), "test needs socket.gethostname()")
def test_sethostname(self):
Expand Down