Visitar URL original
bpo-26187: Tests for sqlite3 trace callback by AnishShah · Pull Request #434 · python/cpython · GitHub
Skip to content

bpo-26187: Tests for sqlite3 trace callback #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AnishShah wants to merge 1 commit into from
Closed

bpo-26187: Tests for sqlite3 trace callback #434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-26187: Tests for sqlite3 trace callback
  • Loading branch information
@AnishShah
AnishShah committed Mar 3, 2017
commit ad5d2f54ad713a645853459eca5fccec43084343
17 changes: 17 additions & 0 deletions Lib/sqlite3/test/hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,23 @@ def trace(statement):
"Unicode data %s garbled in trace callback: %s"
% (ascii(unicode_value), ', '.join(map(ascii, traced_statements))))

def CheckTraceCallbackContent(self):

@berkerpeksag berkerpeksag Mar 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should skip the test if sqlite3_prepare_v2 is not available.

@berkerpeksag berkerpeksag Mar 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test name doesn't explain what we actually testing here.

"""
Test that the statement are correct. Fix for bpo-26187

@berkerpeksag berkerpeksag Mar 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring is not needed.

"""
con = sqlite.connect(":memory:")
traced_statements = []
def trace(statement):
traced_statements.append(statement)
con.set_trace_callback(trace)
queries = ["create table foo(x)", "insert into foo(x) values(1)"]
for query in queries:
con.execute(query)
con.commit()
queries.insert(1, "BEGIN ")
queries.append("COMMIT")

@berkerpeksag berkerpeksag Mar 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines can be removed. We only want to test that set_trace_callback doesn't produce any duplicate entries.

self.assertEqual(traced_statements, queries)



def suite():
Expand Down