Visitar URL original
bpo-29613: Added support for SameSite cookies by alex · Pull Request #6413 · python/cpython · GitHub
Skip to content

bpo-29613: Added support for SameSite cookies #6413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex merged 11 commits into from
Apr 7, 2018
Merged

bpo-29613: Added support for SameSite cookies #6413

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
89c0821
bpo-29613: Added support for SameSite cookies
akash0x53 Feb 21, 2017
3f1b130
Documented SameSite
akash0x53 Feb 21, 2017
7d69cd9
Missing space :(
akash0x53 Feb 21, 2017
b585315
Updated News and contributors
akash0x53 Feb 21, 2017
81446f6
Added version changed details.
akash0x53 Feb 22, 2017
21d0bda
Fix in documentation
akash0x53 Feb 22, 2017
cc06dd1
fix in documentation
akash0x53 Feb 22, 2017
dc750c3
Clubbed test cases for same attribute into single.
akash0x53 Feb 22, 2017
d496c01
Updates
alex Apr 7, 2018
dcd0afa
Style nits + expand tests
alex Apr 7, 2018
9259d2e
review feedback
alex Apr 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clubbed test cases for same attribute into single.
  • Loading branch information
@akash0x53 @alex
akash0x53 authored and alex committed Apr 7, 2018
commit dc750c3452acec05677020fbf5e7b516883d997c
19 changes: 8 additions & 11 deletions Lib/test/test_http_cookies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,14 @@ def test_set_secure_httponly_attrs(self):
self.assertEqual(C.output(),
'Set-Cookie: Customer="WILE_E_COYOTE"; HttpOnly; Secure')

def test_samesite_strict_attrs(self):
C = cookies.SimpleCookie('Customer="WILE_E_COYOTE"')
C['Customer']['samesite'] = "Strict"
self.assertEqual(C.output(),
'Set-Cookie: Customer="WILE_E_COYOTE"; SameSite=Strict')

def test_samesite_lax_attrs(self):
C = cookies.SimpleCookie('Customer="WILE_E_COYOTE"')
C['Customer']['samesite'] = "Lax"
self.assertEqual(C.output(),
'Set-Cookie: Customer="WILE_E_COYOTE"; SameSite=Lax')
def test_samesite_attrs(self):
samesite_values = ("Strict", "Lax")
for val in samesite_values:
with self.subTest(val=val):
C = cookies.SimpleCookie('Customer="WILE_E_COYOTE"')
C['Customer']['samesite'] = val
self.assertEqual(C.output(),
'Set-Cookie: Customer="WILE_E_COYOTE"; SameSite=%s' % val)

def test_secure_httponly_false_if_not_present(self):
C = cookies.SimpleCookie()
Expand Down