Visitar URL original
[3.5] bpo-29643: Fix check for --enable-optimizations by methane · Pull Request #871 · python/cpython · GitHub
Skip to content

[3.5] bpo-29643: Fix check for --enable-optimizations #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 1 commit into from
Mar 28, 2017
Merged

[3.5] bpo-29643: Fix check for --enable-optimizations #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-29643: Fix check for --enable-optimizations (GH-129) 
The presence of the ``--enable-optimizations`` flag is indicated by the
value of ``$enableval``, but the configure script was checking ``$withval``,
resulting in the ``--enable-optimizations`` flag being effectively ignored.
(cherry picked from commit 8cea592)
  • Loading branch information
@ts826848 @methane
ts826848 authored and methane committed Mar 28, 2017
commit fc53fda90bee05d61b822ae448af9e72bfc0590d
5 changes: 5 additions & 0 deletions Misc/NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,11 @@ Documentation

- Issue #29349: Fix Python 2 syntax in code for building the documentation.

Build
-----

- bpo-29643: Fix ``--enable-optimization`` didn't work.

Tests
-----

Expand Down
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6548,7 +6548,7 @@ $as_echo_n "checking for --enable-optimizations... " >&6; }
# Check whether --enable-optimizations was given.
if test "${enable_optimizations+set}" = set; then :
enableval=$enable_optimizations;
if test "$withval" != no
if test "$enableval" != no
then
Py_OPT='true'
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
Expand Down
2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1237,7 +1237,7 @@ Py_OPT='false'
AC_MSG_CHECKING(for --enable-optimizations)
AC_ARG_ENABLE(optimizations, AS_HELP_STRING([--enable-optimizations], [Enable expensive optimizations (PGO, maybe LTO, etc). Disabled by default.]),
[
if test "$withval" != no
if test "$enableval" != no
then
Py_OPT='true'
AC_MSG_RESULT(yes);
Expand Down