Visitar URL original
gh-93162: Add ability to configure QueueHandler/QueueListener together and provide getHandlerByName() and getHandlerNames() APIs. by vsajip · Pull Request #93269 · python/cpython · GitHub
Skip to content

gh-93162: Add ability to configure QueueHandler/QueueListener together and provide getHandlerByName() and getHandlerNames() APIs. #93269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 8 commits into from
Jun 7, 2022
Merged

gh-93162: Add ability to configure QueueHandler/QueueListener together and provide getHandlerByName() and getHandlerNames() APIs. #93269

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3686d74
Add ability to configure QueueHandler/QueueListener together and prov…
vsajip May 25, 2022
2bca114
Improve cross-referencing from the NEWS item.
vsajip May 26, 2022
ef2d96d
Improve documentation and refine test.
vsajip May 27, 2022
debf516
Fix typos, add clarification.
vsajip May 27, 2022
16778fe
Make improvements based on feedback.
vsajip May 30, 2022
42d43b9
Make more improvements based on feedback.
vsajip May 31, 2022
9936dff
Refactor test, add failure cases.
vsajip May 31, 2022
a29ded8
Correct typos in documentation.
vsajip May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typos, add clarification.
  • Loading branch information
@vsajip
vsajip committed May 27, 2022
commit debf516b05c1a235e6d6dc4ea0884e9f2b0e31e4
6 changes: 4 additions & 2 deletions Doc/library/logging.config.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,15 +698,17 @@ If the ``queue`` key is present, the corresponding value can be one of the follo
the :class:`queue.Queue` instance to use. That callable could be a
:class:`queue.Queue` subclass or a function which returns a suitable queue instance.

If the `queue` key is absent, a standard unbounded :class:`queue.Queue` instance is
If the ``queue`` key is absent, a standard unbounded :class:`queue.Queue` instance is
created and used.

If the `listener` key is present, the corresponding value can be one of the following:
If the ``listener`` key is present, the corresponding value can be one of the following:

@iritkatriel iritkatriel May 29, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You say "one of the following" and then there is only one listed?


* A subclass of :class:`logging.handlers.QueueListener`. This is of course only
possible if you are constructing or modifying the configuration dictionary in
code.

If the ``listener`` key is absent, :class:`logging.handlers.QueueListener` is used.

The values under the ``handlers`` key are the names of other handlers in the
configuration (not shown in the above snippet) which will be passed to the queue
listener.
Expand Down