Visitar URL original
GH-93678: reduce boilerplate and code repetition in the compiler by iritkatriel · Pull Request #93682 · python/cpython · GitHub
Skip to content

GH-93678: reduce boilerplate and code repetition in the compiler #93682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 18 commits into from
Jun 14, 2022
Merged

GH-93678: reduce boilerplate and code repetition in the compiler #93682

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
996be64
move line/noline to arg and remove _noline version of functions
iritkatriel Jun 10, 2022
af31e92
add struct location to reduce boilerplate
iritkatriel Jun 10, 2022
f8a0767
merge basicblock_addop, basicblock_addop_i and basicblock_add_jump in…
iritkatriel Jun 10, 2022
430b4b9
add news
iritkatriel Jun 10, 2022
66d5609
assume that oparg is < (1<<30)
iritkatriel Jun 10, 2022
7670a7c
Merge remote-tracking branch 'upstream/main' into codegen-reduce-repe…
iritkatriel Jun 10, 2022
7d74572
use the new location struct for the compiler unit's location
iritkatriel Jun 10, 2022
016ebbc
use the new location struct for the instruction location
iritkatriel Jun 10, 2022
5e06cad
basicblock_addop takes location by reference
iritkatriel Jun 10, 2022
c23e2cf
LOCATION needs to return a const
iritkatriel Jun 10, 2022
fc74555
define static no_location in function scope
iritkatriel Jun 10, 2022
9220fc1
are we const now?
iritkatriel Jun 10, 2022
9b5dc34
trivial stuff
iritkatriel Jun 10, 2022
5330060
Merge remote-tracking branch 'upstream/main' into codegen-reduce-repe…
iritkatriel Jun 13, 2022
414e26a
remove two unused fields from struct assembler
iritkatriel Jun 13, 2022
26dc190
define NO_LOCATION as a static const in global scope
iritkatriel Jun 13, 2022
98d24f2
Merge remote-tracking branch 'upstream/main' into codegen-reduce-repe…
iritkatriel Jun 14, 2022
7851ccd
Merge remote-tracking branch 'upstream/main' into codegen-reduce-repe…
iritkatriel Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merge basicblock_addop, basicblock_addop_i and basicblock_add_jump in… 
…to one functions to reduce unnecessary repetition
  • Loading branch information
@iritkatriel
iritkatriel committed Jun 10, 2022
commit f8a076783d5bbfdaca5a909dfafd184dde47204d
87 changes: 28 additions & 59 deletions Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@
(IS_VIRTUAL_JUMP_OPCODE(opcode) || \
is_bit_set_in_table(_PyOpcode_Jump, opcode))

#define IS_BLOCK_PUSH_OPCODE(opcode) \
((opcode) == SETUP_FINALLY || \
(opcode) == SETUP_WITH || \
(opcode) == SETUP_CLEANUP)

/* opcodes which are not emitted in codegen stage, only by the assembler */
#define IS_ASSEMBLER_OPCODE(opcode) \
((opcode) == JUMP_FORWARD || \
Expand Down Expand Up @@ -191,7 +196,7 @@ static inline int
is_block_push(struct instr *instr)
{
int opcode = instr->i_opcode;
return opcode == SETUP_FINALLY || opcode == SETUP_WITH || opcode == SETUP_CLEANUP;
return IS_BLOCK_PUSH_OPCODE(opcode);
}

static inline int
Expand Down Expand Up @@ -1287,19 +1292,26 @@ compiler_use_new_implicit_block_if_needed(struct compiler *c)
*/

static int
basicblock_addop(basicblock *b, int opcode, struct location loc)
basicblock_addop(basicblock *b, int opcode, int oparg,
basicblock *target, struct location loc)
{
assert(IS_WITHIN_OPCODE_RANGE(opcode));
assert(!IS_ASSEMBLER_OPCODE(opcode));
assert(!HAS_ARG(opcode) || IS_ARTIFICIAL(opcode));
assert(HAS_ARG(opcode) || oparg == 0);
assert(0 <= oparg && oparg <= 2147483647);
Comment thread
iritkatriel marked this conversation as resolved.
Outdated
assert((target == NULL) ||
IS_JUMP_OPCODE(opcode) ||
IS_BLOCK_PUSH_OPCODE(opcode));
assert(oparg == 0 || target == NULL);

int off = basicblock_next_instr(b);
if (off < 0) {
return 0;
}
struct instr *i = &b->b_instr[off];
i->i_opcode = opcode;
i->i_oparg = 0;
i->i_oparg = oparg;
i->i_target = target;
i->i_lineno = loc.lineno;
i->i_end_lineno = loc.end_lineno;
i->i_col_offset = loc.col_offset;
Expand All @@ -1311,12 +1323,13 @@ basicblock_addop(basicblock *b, int opcode, struct location loc)
static int
compiler_addop(struct compiler *c, int opcode, bool line)
{
assert(!HAS_ARG(opcode) || IS_ARTIFICIAL(opcode));
if (compiler_use_new_implicit_block_if_needed(c) < 0) {
return -1;
}

struct location loc = line ? CU_LOCATION(c->u) : NO_LOCATION;
return basicblock_addop(c->u->u_curblock, opcode, loc);
return basicblock_addop(c->u->u_curblock, opcode, 0, NULL, loc);
}

static Py_ssize_t
Expand Down Expand Up @@ -1507,11 +1520,12 @@ compiler_addop_name(struct compiler *c, int opcode, PyObject *dict,
/* Add an opcode with an integer argument.
Returns 0 on failure, 1 on success.
*/

static int
basicblock_addop_i(basicblock *b, int opcode, Py_ssize_t oparg,
struct location loc)
compiler_addop_i(struct compiler *c, int opcode, Py_ssize_t oparg, bool line)
{
if (compiler_use_new_implicit_block_if_needed(c) < 0) {
return -1;
}
/* oparg value is unsigned, but a signed C int is usually used to store
it in the C code (like Python/ceval.c).

Expand All @@ -1520,57 +1534,10 @@ basicblock_addop_i(basicblock *b, int opcode, Py_ssize_t oparg,
The argument of a concrete bytecode instruction is limited to 8-bit.
EXTENDED_ARG is used for 16, 24, and 32-bit arguments. */

assert(IS_WITHIN_OPCODE_RANGE(opcode));
assert(!IS_ASSEMBLER_OPCODE(opcode));
assert(0 <= oparg && oparg <= 2147483647);

int off = basicblock_next_instr(b);
if (off < 0) {
return 0;
}
struct instr *i = &b->b_instr[off];
i->i_opcode = opcode;
i->i_oparg = Py_SAFE_DOWNCAST(oparg, Py_ssize_t, int);
i->i_lineno = loc.lineno;
i->i_end_lineno = loc.end_lineno;
i->i_col_offset = loc.col_offset;
i->i_end_col_offset = loc.end_col_offset;
int oparg_ = Py_SAFE_DOWNCAST(oparg, Py_ssize_t, int);

return 1;
}

static int
compiler_addop_i(struct compiler *c, int opcode, Py_ssize_t oparg, bool line)
{
if (compiler_use_new_implicit_block_if_needed(c) < 0) {
return -1;
}
struct location loc = line ? CU_LOCATION(c->u) : NO_LOCATION;
return basicblock_addop_i(c->u->u_curblock, opcode, oparg, loc);
}

static int
basicblock_add_jump(basicblock *b, int opcode,
struct location loc, basicblock *target)
{
assert(IS_WITHIN_OPCODE_RANGE(opcode));
assert(!IS_ASSEMBLER_OPCODE(opcode));
assert(HAS_ARG(opcode) || IS_VIRTUAL_OPCODE(opcode));
assert(target != NULL);

int off = basicblock_next_instr(b);
struct instr *i = &b->b_instr[off];
if (off < 0) {
return 0;
}
i->i_opcode = opcode;
i->i_target = target;
i->i_lineno = loc.lineno;
i->i_end_lineno = loc.end_lineno;
i->i_col_offset = loc.col_offset;
i->i_end_col_offset = loc.end_col_offset;

return 1;
return basicblock_addop(c->u->u_curblock, opcode, oparg_, NULL, loc);
}

static int
Expand All @@ -1580,7 +1547,9 @@ compiler_addop_j(struct compiler *c, int opcode, basicblock *target, bool line)
return -1;
}
struct location loc = line ? CU_LOCATION(c->u) : NO_LOCATION;
return basicblock_add_jump(c->u->u_curblock, opcode, loc, target);
assert(target != NULL);
assert(IS_JUMP_OPCODE(opcode) || IS_BLOCK_PUSH_OPCODE(opcode));
return basicblock_addop(c->u->u_curblock, opcode, 0, target, loc);
}

#define ADDOP(C, OP) { \
Expand Down Expand Up @@ -7455,7 +7424,7 @@ push_cold_blocks_to_end(struct compiler *c, basicblock *entry, int code_flags) {
if (explicit_jump == NULL) {
return -1;
}
basicblock_add_jump(explicit_jump, JUMP, NO_LOCATION, b->b_next);
basicblock_addop(explicit_jump, JUMP, 0, b->b_next, NO_LOCATION);

explicit_jump->b_cold = 1;
explicit_jump->b_next = b->b_next;
Expand Down