Visitar URL original
gh-93761: Fix test_logging test_config_queue_handler() race condition by vstinner · Pull Request #93952 · python/cpython · GitHub
Skip to content

gh-93761: Fix test_logging test_config_queue_handler() race condition #93952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Jun 19, 2022
Merged

gh-93761: Fix test_logging test_config_queue_handler() race condition #93952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-93761: Fix test_logging test_config_queue_handler() race condition 
Fix a race condition in test_config_queue_handler() of test_logging.
  • Loading branch information
@vstinner
vstinner committed Jun 17, 2022
commit 144abf2a7ff7f64f69664d795cd3a475f6f0f736
3 changes: 3 additions & 0 deletions Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3603,6 +3603,9 @@ def do_queuehandler_configuration(self, qspec, lspec):
if qh.listener.queue.empty():
break

# wait until the handler completed its last task
qh.listener.queue.join()

with open(fn, encoding='utf-8') as f:
data = f.read().splitlines()
self.assertEqual(data, ['foo', 'bar', 'baz'])
Expand Down