Visitar URL original
[3.11] GH-93990: fix refcounting bug in `add_subclass` in `typeobject.c` (GH-93989) by miss-islington · Pull Request #93998 · python/cpython · GitHub
Skip to content

[3.11] GH-93990: fix refcounting bug in add_subclass in typeobject.c (GH-93989) #93998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Jun 19, 2022
Merged

[3.11] GH-93990: fix refcounting bug in add_subclass in typeobject.c (GH-93989) #93998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
GH-93990: fix refcounting bug in add_subclass in typeobject.c (GH… 
…-93989)

(cherry picked from commit 726448e)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
  • Loading branch information
@kumaraditya303 @miss-islington
kumaraditya303 authored and miss-islington committed Jun 19, 2022
commit b95735596ba7889ed4f972c50fce1cbd688c93d4
5 changes: 4 additions & 1 deletion Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6512,8 +6512,11 @@ add_subclass(PyTypeObject *base, PyTypeObject *type)
PyObject *subclasses = base->tp_subclasses;
if (subclasses == NULL) {
base->tp_subclasses = subclasses = PyDict_New();
if (subclasses == NULL)
if (subclasses == NULL) {
Py_DECREF(key);
Py_DECREF(ref);
return -1;
}
}
assert(PyDict_CheckExact(subclasses));

Expand Down