Visitar URL original
GH-94694: Fix column offsets for multi-line method lookups by brandtbucher · Pull Request #94697 · python/cpython · GitHub
Skip to content

GH-94694: Fix column offsets for multi-line method lookups #94697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 6 commits into from
Jul 10, 2022
Merged

GH-94694: Fix column offsets for multi-line method lookups #94697

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
937a3db
Add failing regression test
brandtbucher Jul 8, 2022
dd5a391
Fix invalid column math
brandtbucher Jul 8, 2022
ffd3413
Add additional tests for column locations
brandtbucher Jul 8, 2022
53ba444
blurb add
brandtbucher Jul 8, 2022
33dc4d8
Update comment
brandtbucher Jul 8, 2022
13c07ff
Feedback from code review
brandtbucher Jul 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comment
  • Loading branch information
@brandtbucher
brandtbucher committed Jul 8, 2022
commit 33dc4d8a911512fa310dc262b1c641f26c89cc9d
3 changes: 2 additions & 1 deletion Lib/test/test_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,7 +1182,8 @@ def test_complex_single_line_expression(self):
line=1, end_line=1, column=0, end_column=27, occurrence=4)

def test_multiline_assert_rewritten_as_method_call(self):
# GH-94694
# GH-94694: Copying location information from a "real" node to a
# handwritten one should always be valid!

@iritkatriel iritkatriel Jul 9, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it really always be valid?

@brandtbucher brandtbucher Jul 9, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove the comment if it's too controversial. It just seems to me that the utility/safety of ast.copy_location and ast.fix_missing_locations is dramatically reduced if they can't at least promise crash-free behavior.

tree = ast.parse("assert (\n42\n)")
old_node = tree.body[0]
new_node = ast.Expr(
Expand Down