Visitar URL original
gh-95196: Disable incorrect pickling of the C implemented classmethod descriptors by serhiy-storchaka · Pull Request #96383 · python/cpython · GitHub
Skip to content

gh-95196: Disable incorrect pickling of the C implemented classmethod descriptors #96383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 4 commits into from
Oct 5, 2022
Merged

gh-95196: Disable incorrect pickling of the C implemented classmethod descriptors #96383

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abe2e5a
gh-95196: Disable incorrect pickling of the C implemented classmethod…
serhiy-storchaka Aug 29, 2022
d79301d
Fix debugging remnants.
serhiy-storchaka Aug 29, 2022
06880bb
Merge branch 'main' into c-classmethod-descriptor-reduce
serhiy-storchaka Oct 5, 2022
dadbf00
Add some comments.
serhiy-storchaka Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add some comments.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Oct 5, 2022
commit dadbf009c51b52f1f8a5066c798b0c3d4bba53c4
8 changes: 4 additions & 4 deletions Lib/test/pickletester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2777,8 +2777,8 @@ def pie(self):
self.assertEqual(method(obj), unpickled(obj))

descriptors = (
PyMethodsTest.__dict__['cheese'],
PyMethodsTest.__dict__['wine'],
PyMethodsTest.__dict__['cheese'], # static method descriptor
PyMethodsTest.__dict__['wine'], # class method descriptor
)
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
for descr in descriptors:
Expand Down Expand Up @@ -2821,8 +2821,8 @@ class Nested(str):
self.assertEqual(method(*args), unpickled(*args))

descriptors = (
bytearray.__dict__['maketrans'],
dict.__dict__['fromkeys'],
bytearray.__dict__['maketrans'], # built-in static method descriptor
dict.__dict__['fromkeys'], # built-in class method descriptor
)
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
for descr in descriptors:
Expand Down