Visitar URL original
[3.9] gh-95778: CVE-2020-10735: Prevent DoS by very large int() by gpshead · Pull Request #96502 · python/cpython · GitHub
Skip to content

[3.9] gh-95778: CVE-2020-10735: Prevent DoS by very large int() #96502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 15 commits into from
Sep 5, 2022
Merged

[3.9] gh-95778: CVE-2020-10735: Prevent DoS by very large int() #96502

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
576d772
Backport to 3.9 of psrt/CVE-2020-10735-3.10backport.
gpshead Aug 19, 2022
e5cd3fc
Fix versionadded/versionchanged.
gpshead Aug 21, 2022
9a3cd05
headers += Include/internal/pycore_long.h
gpshead Aug 21, 2022
c190dc9
Update attribution in Misc/NEWS.d
gpshead Aug 25, 2022
a7213dd
Manually add new field to abi file
tiran Sep 1, 2022
2384ef4
Move the whatsnew text per review.
gpshead Sep 1, 2022
fcb123b
Merge branch 'CVE-2020-10735-3.9backport' of github.com:python/psrt i…
gpshead Sep 1, 2022
1378bde
Make the doctest actually run & fix it.
gpshead Sep 1, 2022
e51a8e2
Fix the docs build.
gpshead Sep 2, 2022
3e7eb9c
Rename the news file to appease the Bedevere bot.
gpshead Sep 2, 2022
5c64ec6
hexadecimal spelling =)
gpshead Sep 2, 2022
a37041f
doc typo: limitation
gpshead Sep 4, 2022
b4957d8
Misc: Fix a typo in the header comment.
gpshead Sep 4, 2022
0515141
remove unneeded doc note on float.as_integer_ratio
gpshead Sep 4, 2022
a1247fd
gh-95778: Correctly pre-check for int-to-str conversion (#96537)
mdickinson Sep 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move the whatsnew text per review. 
Ned pointed this out on the 3.7 review, it matches other patch
changes and stands out better.
  • Loading branch information
@gpshead
gpshead committed Sep 1, 2022
commit 2384ef41bca2cb920aadfc0d8442efd73283a3d1
26 changes: 14 additions & 12 deletions Doc/whatsnew/3.9.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,18 +271,6 @@ Other Language Changes
``if`` clause in comprehensions and generator expressions. See :issue:`41848`
and :issue:`43755` for details.

* New security feature in 3.9.14:
Converting between :class:`int` and :class:`str` in bases other than 2
(binary), 4, 8 (octal), 16 (hexidecimal), or 32 such as base 10 (decimal)
now raises a :exc:`ValueError` if the number of digits in string form is
above a limit to avoid potential denial of service attacks due to the
algorithmic complexity. This is a mitigation for `CVE-2020-10735
<https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-10735>`_.
This limit can be configured or disabled by environment variable, command
line flag, or :mod:`sys` APIs. See the :ref:`integer string conversion
length limitation <int_max_str_digits>` documentation. The default limit
is 4300 digits in string form.


New Modules
===========
Expand Down Expand Up @@ -1599,3 +1587,17 @@ URL by the parser in :mod:`urllib.parse` preventing such attacks. The removal
characters are controlled by a new module level variable
``urllib.parse._UNSAFE_URL_BYTES_TO_REMOVE``. (See :issue:`43882`)

Notable security feature in 3.9.14
==================================

Converting between :class:`int` and :class:`str` in bases other than 2
(binary), 4, 8 (octal), 16 (hexidecimal), or 32 such as base 10 (decimal)
now raises a :exc:`ValueError` if the number of digits in string form is
above a limit to avoid potential denial of service attacks due to the
algorithmic complexity. This is a mitigation for `CVE-2020-10735
<https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-10735>`_.
This limit can be configured or disabled by environment variable, command
line flag, or :mod:`sys` APIs. See the :ref:`integer string conversion
length limitation <int_max_str_digits>` documentation. The default limit
is 4300 digits in string form.