Visitar URL original
[3.11] GH-88050: fix race in closing subprocess pipe in asyncio (GH-97951) by miss-islington · Pull Request #97978 · python/cpython · GitHub
Skip to content

[3.11] GH-88050: fix race in closing subprocess pipe in asyncio (GH-97951) #97978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 1 commit into from
Oct 6, 2022
Merged

[3.11] GH-88050: fix race in closing subprocess pipe in asyncio (GH-97951) #97978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
GH-88050: fix race in closing subprocess pipe in asyncio (GH-97951) 
Check for None when iterating over `self._pipes.values()`.
(cherry picked from commit e2e6b95)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
  • Loading branch information
@kumaraditya303 @miss-islington
kumaraditya303 authored and miss-islington committed Oct 6, 2022
commit 2e5886a4db57a15324ea023c61912d3976c2cebd
4 changes: 3 additions & 1 deletion Lib/asyncio/base_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,9 @@ def _process_exited(self, returncode):
self._proc.returncode = returncode
self._call(self._protocol.process_exited)
for p in self._pipes.values():
p.pipe.close()
if p is not None:
p.pipe.close()

self._try_finish()

async def _wait(self):
Expand Down